Skip to content

Fix doStash and doStart tasks undo logic#510

Draft
dmitry-lyfar wants to merge 1 commit into
mainfrom
fix/handling-cancellations
Draft

Fix doStash and doStart tasks undo logic#510
dmitry-lyfar wants to merge 1 commit into
mainfrom
fix/handling-cancellations

Conversation

@dmitry-lyfar

Copy link
Copy Markdown
Collaborator

Description

Self-review quick check

  • Make decisions that cost a lot to reverse explicit in the PR description.
  • Avoid nested conditions.
  • Delete dead code and redundant comments.
  • Normalise symmetries by sticking to doing identical things identically.
// one way to handle errors
if err := f(); err != nil {
   ...
}

// one way to handle multiple returns
val, err := f()
if err != nil {
   ...
}
...
  • Check that coupled code elements, files, and directories are adjacent. For example, test data is stored as close as possible to a test.
  • Put variable declaration and initialisation together.
  • Divide large expressions into digestable and self-explanatory ones. Use multiple variables if required.
  • Put a blank line between two logically different chunks of code.
  • Follow the style guide for new error messages.

Docs

  • I have checked and added or updated relevant documentation.
  • I have checked and added or updated relevant release notes.
  • I have included the technical author in the review.

Or:

  • I confirm the PR has no implications for documentation.

@dmitry-lyfar dmitry-lyfar force-pushed the fix/handling-cancellations branch 2 times, most recently from 0175bb9 to bc32999 Compare October 20, 2025 03:11
@github-actions

Copy link
Copy Markdown
Contributor

TICS Quality Gate

✔️ Passed

workshop

All conditions passed

See the results in the TICS Viewer

The following files have been checked for this project
  • internal/overlord/workshopstate/handlers.go
  • internal/workshop/lxd/lxd_backend_layers.go
  • internal/workshop/lxd/lxd_backend.go

Automatic-tests / code-coverage / TICS GitHub Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant