Skip to content

Remember connections across refreshes#817

Draft
jonathan-conder wants to merge 3 commits into
mainfrom
fix/refresh-forgets-connections
Draft

Remember connections across refreshes#817
jonathan-conder wants to merge 3 commits into
mainfrom
fix/refresh-forgets-connections

Conversation

@jonathan-conder

@jonathan-conder jonathan-conder commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Description

Remember interface connections across refreshes by saving disconnect state and restoring previously connected manual links during auto-connect.

This PR now also:

  • preserves the original auto/manual connection state when a remembered connection is restored
  • replaces new manual map-copy loops with maps.Copy
  • adds focused regression coverage for saving and restoring remembered connections across refreshes

Validation:

  • go test ./internal/overlord/ifacestate/...

Self-review quick check

  • Make decisions that cost a lot to reverse explicit in the PR description.
  • Avoid nested conditions.
  • Delete dead code and redundant comments.
  • Normalise symmetries by sticking to doing identical things identically.
// one way to handle errors
if err := f(); err != nil {
   ...
}

// one way to handle multiple returns
val, err := f()
if err != nil {
   ...
}
...
  • Check that coupled code elements, files, and directories are adjacent. For example, test data is stored as close as possible to a test.
  • Put variable declaration and initialisation together.
  • Divide large expressions into digestable and self-explanatory ones. Use multiple variables if required.
  • Put a blank line between two logically different chunks of code.
  • Follow the style guide for new error messages.

Docs

Procedure:

  • I have checked and added or updated relevant documentation.
  • I have checked and added or updated relevant release notes.
  • I have included the technical author in the review.

Content:

  • Headings and titles accurately describe the content.
  • New and updated pages include correct metadata.
  • Documentation tests are added or updated where applicable (for tutorial/ and how-to/ sections).
  • Documentation follows the style guide.
  • If needed, docs/.coverage.yaml updated, coverage tags added (.. artefact).

Or:

  • I confirm the PR has no implications for documentation.

@jonathan-conder jonathan-conder self-assigned this Jun 3, 2026
@jonathan-conder

Copy link
Copy Markdown
Contributor Author

@copilot fix the linter issues within this PR (i.e. use maps.Copy)

Copilot AI commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@copilot fix the linter issues within this PR (i.e. use maps.Copy)

Addressed in cf759c2.

@jonathan-conder

Copy link
Copy Markdown
Contributor Author

@copilot also add some test coverage while you're at it

Copilot AI commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@copilot also add some test coverage while you're at it

Addressed in a30f2aa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants