Conversation
| echo "Welcome to Canopy Setup!" | ||
| echo | ||
|
|
||
| CONFIG_FILE=setup.conf |
There was a problem hiding this comment.
You should add an example of this file in the repo
There was a problem hiding this comment.
Will do if we like this approach.
setup.sh
Outdated
| } | ||
|
|
||
| # Function to save config to a file | ||
| save_config() { |
There was a problem hiding this comment.
this function is not idempotent, although the setup is meant to be ran once, I think we should protect against people who may want to use this as a way to update their files (or may run it multiple times if they're having issues for whatever reason)
There was a problem hiding this comment.
digging more into the code there's an autoload option so even more reasons to make this idempotent
There was a problem hiding this comment.
Yes the config file is only overwritten if the user opts to enter the values again.
The main purpose was for headless installs and running multiple times. Thinking again however I think we can remove the save functionality altogether and just have it read the file if it is present.
3 participants
-Banner
-Setup config saving