feat: port backports from splice-shared-gha#5807
Conversation
8105249 to
66bd7dc
Compare
0404559 to
73309be
Compare
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
73309be to
88b58e9
Compare
|
@krzysztofczyz-da, I wonder if we shouldn't just move stuff from |
| "gha-scripts/actions/parse_backport_comments/", | ||
| "gha-scripts/actions/backport_reminder" |
There was a problem hiding this comment.
| "gha-scripts/actions/parse_backport_comments/", | |
| "gha-scripts/actions/backport_reminder" | |
| "gha-scripts/actions/**/*.js" |
would be more correct but I guess we can't use globs here.
mblaze-da
left a comment
There was a problem hiding this comment.
I'd consider moving to .github now if there are no issues with that. Thanks!
I think this setup is a bit easier to maintain as it is easier to spot what this thing does, where the code lies, etc. |
I don't think it will cause any particular, technical issues. Just that it's a bit confusing why we split off just this part of our GHA scripts while the rest stays in |
Also: remove one unneeded action
.github/actions/setup/action.ymlNote: using a separate dir to make it easy to see that this a separate component (also easier to manage).