Skip to content

feat: port backports from splice-shared-gha#5807

Merged
krzysztofczyz-da merged 6 commits into
mainfrom
kczyz/add-backports
Jun 24, 2026
Merged

feat: port backports from splice-shared-gha#5807
krzysztofczyz-da merged 6 commits into
mainfrom
kczyz/add-backports

Conversation

@krzysztofczyz-da

@krzysztofczyz-da krzysztofczyz-da commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Also: remove one unneeded action .github/actions/setup/action.yml

Note: using a separate dir to make it easy to see that this a separate component (also easier to manage).

@krzysztofczyz-da krzysztofczyz-da added the static Used to label PRs for which static tests suffice label Jun 8, 2026
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
@mblaze-da

Copy link
Copy Markdown
Contributor

@krzysztofczyz-da, I wonder if we shouldn't just move stuff from gha-scripts into .github to keep the directory structure simple.

Comment on lines +316 to +317
"gha-scripts/actions/parse_backport_comments/",
"gha-scripts/actions/backport_reminder"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"gha-scripts/actions/parse_backport_comments/",
"gha-scripts/actions/backport_reminder"
"gha-scripts/actions/**/*.js"

would be more correct but I guess we can't use globs here.

@mblaze-da mblaze-da left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider moving to .github now if there are no issues with that. Thanks!

@krzysztofczyz-da

Copy link
Copy Markdown
Contributor Author

I'd consider moving to .github now if there are no issues with that. Thanks!

I think this setup is a bit easier to maintain as it is easier to spot what this thing does, where the code lies, etc.
I'm happy to reconsider if this proves to be problematic in the future

@krzysztofczyz-da krzysztofczyz-da merged commit dab9153 into main Jun 24, 2026
48 checks passed
@krzysztofczyz-da krzysztofczyz-da deleted the kczyz/add-backports branch June 24, 2026 07:54
@mblaze-da

Copy link
Copy Markdown
Contributor

I think this setup is a bit easier to maintain as it is easier to spot what this thing does, where the code lies, etc. I'm happy to reconsider if this proves to be problematic in the future

I don't think it will cause any particular, technical issues. Just that it's a bit confusing why we split off just this part of our GHA scripts while the rest stays in .github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

static Used to label PRs for which static tests suffice

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants