helm, info, status: Check snapshot timestamp for Scan#6205
Open
giner wants to merge 1 commit into
Open
Conversation
giner
commented
Jul 2, 2026
giner
commented
Contributor
- Report Scan as lagging if the last snapshot timestamp is older than 4 hours
- Split reachability and lagging reports (1 means lagging, 2 means unreachable)
- Report Scan as lagging if the last snapshot timestamp is older than 4 hours - Split reachability and lagging reports (1 means lagging, 2 means unreachable) Signed-off-by: Stanislav German-Evtushenko <ginermail@gmail.com>
giner
force-pushed
the
stas/helm_info_status_check_snapshot_timestamp_for_scan
branch
from
22cd809 to
aed1452
Compare
martinflorian-da
approved these changes
Jul 2, 2026
martinflorian-da
left a comment
martinflorian-da
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks! Not bothering with a cluster test as AFAICT it wouldn't catch any regressions here anyway.
@giner let us know when you're ready to merge
| sv: {nodes: $sv, description: "Last status report within \($sv_threshold) seconds"}, | ||
| mediator: {nodes: $mediator, description: "Last acknowledgment within \($mediator_threshold) seconds"}, | ||
| scan: {nodes: $scan, description: "Reachable, last open and issuing rounds are within \($scan_threshold) seconds"}, | ||
| scan: {nodes: $scan, description: "Reachable, last open and issuing rounds are within \($scan_threshold_rounds) seconds and last snapshot is within \($scan_threshold_snapshot) seconds"}, |
Contributor
There was a problem hiding this comment.
Do you want to explain here that 1 now means lagging and 2 actually unreachable?
Contributor
Author
There was a problem hiding this comment.
The description goes to the UI and having codes explained there may be too verbose and confusing
Contributor
Author
There was a problem hiding this comment.
We could add one more key description_details if you think it's worth it
martinflorian-da
added
the
static
Contributor
Author
It's ready. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.