Scan: Use FA weights in app activity computation#6208
Draft
dfordivam wants to merge 3 commits into
Draft
Conversation
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
meiersi-da
reviewed
Jul 2, 2026
meiersi-da
left a comment
meiersi-da
left a comment
Contributor
There was a problem hiding this comment.
Very nice! Exactly what we were looking for 👏
|
|
||
| // Convert the assigned activity back to burn amount using app weight | ||
| val reconstructedBurnSum = activity.records.map { r => | ||
| val weight = scaledProvider match { |
Contributor
There was a problem hiding this comment.
Suggested change
| val weight = scaledProvider match { | |
| val activityWeight = scaledProvider match { |
|
|
||
| val aggregatedWeights = SortedMap.from(aggregatedBurn.map { case (party, burn) => | ||
| val weight = | ||
| featuredAppWeights.getOrElse(party, DbScanRewardsReferenceStore.DefaultAppActivityWeight) |
Contributor
There was a problem hiding this comment.
Why do we need the default weight here? The lookup should never fail, or not?
| val aggregatedWeights = SortedMap.from(aggregatedBurn.map { case (party, burn) => | ||
| val weight = | ||
| featuredAppWeights.getOrElse(party, DbScanRewardsReferenceStore.DefaultAppActivityWeight) | ||
| party -> (BigDecimal(burn) * weight).toLong |
Contributor
There was a problem hiding this comment.
Oh this is an interesting snag: having to change to do the rounding here. Let's use Daml's Decimal arithmetic as described here: canton-foundation/cips#238 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For preview of the implementation, based on #6178
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines