[OLYMPUS-1470]: Convert the settings class property defaults test into a common PHPStan rule#119
Merged
Orrison merged 3 commits intoJul 13, 2026
Conversation
mittal-canyon
marked this pull request as draft
July 10, 2026 13:25
mittal-canyon
force-pushed
the
feature/settings-properties-must-have-defaults-rule
branch
from
July 10, 2026 13:30
c6de145 to
4a3aa5e
Compare
mittal-canyon
requested review from
Orrison and
Copilot
and removed request for
Copilot and
payal-canyon
July 10, 2026 13:32
mittal-canyon
force-pushed
the
feature/settings-properties-must-have-defaults-rule
branch
from
July 10, 2026 13:51
c6aa9d4 to
7222054
Compare
mittal-canyon
marked this pull request as ready for review
July 10, 2026 14:01
Orrison
approved these changes
Jul 13, 2026
- Remove redundant getName() !== check from guard condition; isSubclassOf() already returns false for the class itself, and PHPStan flags the class-string strict comparison as always-true - Add tests/PHPStan/Configs/settings-properties-must-have-defaults.neon following the per-rule config pattern used by all other rule tests - Update test helper to reference the new config instead of phpstan-test.neon
Orrison
force-pushed
the
feature/settings-properties-must-have-defaults-rule
branch
from
July 13, 2026 20:01
92ce5df to
107e0c4
Compare
Orrison
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket(s) or GitHub Issue
Technical Description
Any deployment steps required?
Are any Feature Flags and/or Data Migrations that can eventually be removed added?
Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.