[ADVAPP-2767]: Implement the resource hub portal login page#121
Open
nency-canyon wants to merge 1 commit into
Open
[ADVAPP-2767]: Implement the resource hub portal login page#121nency-canyon wants to merge 1 commit into
nency-canyon wants to merge 1 commit into
Conversation
nency-canyon
force-pushed
the
feat/portal-login-component
branch
from
July 13, 2026 16:53
64eaaec to
8964b4f
Compare
nency-canyon
marked this pull request as ready for review
July 13, 2026 17:00
nency-canyon
force-pushed
the
feat/portal-login-component
branch
from
July 16, 2026 10:38
8964b4f to
22851e7
Compare
nency-canyon
force-pushed
the
feat/portal-login-component
branch
from
July 17, 2026 14:13
22851e7 to
5f96e84
Compare
danharrin
requested changes
Jul 17, 2026
danharrin
left a comment
danharrin
left a comment
Contributor
There was a problem hiding this comment.
I think that the login form itself should be abstracted and not just the layout around it, what do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket(s) or GitHub Issue
NA
Technical Description
Any deployment steps required?
Are any Feature Flags and/or Data Migrations that can eventually be removed Added?
Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.