Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,8 @@ The generated `chart/values.yaml` contains two types of information:
```sh
kubectl get gateway -n kyma-system kyma-gateway -o jsonpath='{.spec.servers[0].hosts[0]}'
```
* **Global Account ID (globalAccountId) *[Mandatory]*** - SAP BTP Global Account Identifier where services are entitled for the application.
* **Global Account ID (globalAccountId) *[Mandatory for now; will be removed soon]*** - SAP BTP Global Account Identifier where services are entitled for the application.
* **Provider Subaccount ID (providerSubaccountId) *[Mandatory]*** - The Subaccount ID of the provider subaccount to which you deploy the application.
* **Provider subdomain (providerSubdomain) *[Mandatory for applications; it does not apply to services-only scenarios]*** - Subdomain of the provider subaccount to which you deploy the application.
* **Tenant ID (tenantId) *[Mandatory for applications; it does not apply to services-only scenarios]*** - Tenant ID of the provider subaccount to which you deploy the application.
* **HANA Instance ID (hanaInstanceId) *[Optional]*** - ID of the SAP HANA instance to which the application is deployed. It's only required if there are multiple SAP HANA instances in the subaccount.
Expand Down Expand Up @@ -187,13 +188,14 @@ The generated `chart/values.yaml` contains two types of information:
capOperatorSubdomain: cap-op
clusterDomain: abc.com
globalAccountId: abcdef-abcd-4ef1-9263-1b6b7b6b7b6b
providerSubaccountId: da37c8e0-74d4-abcd-b5e2-sd8f7d8f7d8f
providerSubdomain: provider-subdomain-1234
tenantId: da37c8e0-74d4-abcd-b5e2-sd8f7d8f7d8f
hanaInstanceId: 46e285d9-abcd-4c7d-8ebb-502sd8f7d8f7d
imagePullSecret: regcred
```

Similar to the interactive mode, `appName`, `capOperatorSubdomain`, `clusterDomain`, `globalAccountId`, `providerSubdomain`, and `tenantId` are mandatory fields for applications. In case of services-only scenarios, `appName`, `capOperatorSubdomain`, `clusterDomain`, and `globalAccountId` are mandatory. The plugin throws an error if they're not provided in the input YAML.
Similar to the interactive mode, `appName`, `capOperatorSubdomain`, `clusterDomain`, `globalAccountId`, `providerSubaccountId`, `providerSubdomain`, and `tenantId` are mandatory fields for applications. In case of services-only scenarios, `appName`, `capOperatorSubdomain`, `clusterDomain`, and `globalAccountId`, `providerSubaccountId` are mandatory. The plugin throws an error if they're not provided in the input YAML.

After execution, the `runtime-values.yaml` file is created in the chart folder of your project directory.

Expand Down
7 changes: 4 additions & 3 deletions bin/cap-op-plugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,8 @@ async function generateRuntimeValues(option, inputYamlPath) {
answerStruct = yaml.parse(await cds.utils.read(cds.utils.path.join(cds.root, inputYamlPath)))

const requiredFields = isServiceOnly
? ['appName', 'capOperatorSubdomain', 'clusterDomain', 'globalAccountId']
: ['appName', 'capOperatorSubdomain', 'clusterDomain', 'globalAccountId', 'providerSubdomain', 'tenantId']
? ['appName', 'capOperatorSubdomain', 'clusterDomain', 'globalAccountId', 'providerSubaccountId']
: ['appName', 'capOperatorSubdomain', 'clusterDomain', 'globalAccountId', 'providerSubaccountId', 'providerSubdomain', 'tenantId']
Comment on lines +187 to +188
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic Error: Inconsistency in globalAccountId required status

The globalAccountId is listed as a required field here (lines 187-188), but in the schema files (files/chart/values.schema.json and files/configurableTemplatesChart/values.schema.json), it has been removed from the required array, and in hack/schema-generation.go:47 it's marked with omitempty. This creates an inconsistency where the plugin will reject YAML files missing globalAccountId even though the schema allows it to be optional.

Either globalAccountId should remain required in all places, or it should be made optional everywhere. Based on the PR description mentioning "misc adjustments until the field becomes mandatory (soon)", it appears both fields should be optional for now.

Suggested change
? ['appName', 'capOperatorSubdomain', 'clusterDomain', 'globalAccountId', 'providerSubaccountId']
: ['appName', 'capOperatorSubdomain', 'clusterDomain', 'globalAccountId', 'providerSubaccountId', 'providerSubdomain', 'tenantId']
const requiredFields = isServiceOnly
? ['appName', 'capOperatorSubdomain', 'clusterDomain', 'providerSubaccountId']
: ['appName', 'capOperatorSubdomain', 'clusterDomain', 'providerSubaccountId', 'providerSubdomain', 'tenantId']

Double-check suggestion before committing. Edit this comment for amendments.


Please provide feedback on the review comment by checking the appropriate box:

  • 🌟 Awesome comment, a human might have missed that.
  • ✅ Helpful comment
  • 🤷 Neutral
  • ❌ This comment is not helpful


const missingFields = requiredFields.filter(field => !answerStruct[field])
if (missingFields.length) {
Expand All @@ -198,14 +198,15 @@ async function generateRuntimeValues(option, inputYamlPath) {
['Enter CAP Operator subdomain (In kyma cluster it is "cap-op" by default): ', 'cap-op', true],
['Enter your cluster shoot domain: ', await getShootDomain(), true],
['Enter your global account ID: ', '', true],
['Enter your provider sub-account ID: ', '', true],
...isServiceOnly ? [] : [['Enter your provider subdomain: ', '', true]],
...isServiceOnly ? [] : [['Enter your provider tenant ID: ', '', true]],
['Enter your HANA database instance ID: ', '', false],
['Enter your image pull secrets: ', '', false]
]

const answerKeys = [
'appName', 'capOperatorSubdomain', 'clusterDomain', 'globalAccountId',
'appName', 'capOperatorSubdomain', 'clusterDomain', 'globalAccountId', 'providerSubaccountId',
...isServiceOnly ? [] : ['providerSubdomain'],
...isServiceOnly ? [] : ['tenantId'],
'hanaInstanceId', 'imagePullSecret'
Expand Down
4 changes: 3 additions & 1 deletion files/chart/values.yaml.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ app:

btp:
# -- BTP Global account identifier where the application is hosted
globalAccountId: # mandatory let helm fail if not provided
globalAccountId:
# -- BTP Provider sub-account identifier where the application is hosted
providerSubaccountId:
{{#isApp}}
provider:
# -- Subdomain of the provider sub-account where application services are created
Expand Down
4 changes: 3 additions & 1 deletion files/configurableTemplatesChart/values.yaml.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ app:

btp:
# -- BTP Global account identifier where the application is hosted
globalAccountId: # mandatory let helm fail if not provided
globalAccountId:
# -- BTP Provider sub-account identifier where the application is hosted
providerSubaccountId:
{{#isApp}}
provider:
# -- Subdomain of the provider sub-account where application services are created
Expand Down
1 change: 1 addition & 0 deletions files/runtime-values.yaml.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ app:

btp:
globalAccountId: {{globalAccountId}}
providerSubaccountId: {{providerSubaccountId}}
{{#isApp}}
provider:
subdomain: {{providerSubdomain}}
Expand Down
3 changes: 2 additions & 1 deletion lib/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,8 @@ function writeCAPApplicationCRO(yaml, hasIas, isService) {
' name: {{ .name }}',
'{{- end }}',
'btpAppName: {{ include "appName" $ }}',
'globalAccountId: {{ .Values.btp.globalAccountId }}'
'globalAccountId: {{ .Values.btp.globalAccountId }}',
'providerSubaccountId: {{ .Values.btp.providerSubaccountId }}'
])

if (!isService) {
Expand Down
46 changes: 26 additions & 20 deletions test/cap-op-plugin.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,11 @@ EXAMPLES
rlQuestion.onSecondCall().callsArgWith(1, '')
rlQuestion.onThirdCall().callsArgWith(1, 'c-abc.kyma.ondemand.com')
rlQuestion.onCall(3).callsArgWith(1, 'dc94db56-asda-adssa-dada-123456789012')
rlQuestion.onCall(4).callsArgWith(1, 'bem-aad-sadad-123456789012')
rlQuestion.onCall(5).callsArgWith(1, 'dasdsd-1234-1234-1234-123456789012')
rlQuestion.onCall(6).callsArgWith(1, 'sdasd-4c4d-4d4d-4d4d-123456789012')
rlQuestion.onCall(7).callsArgWith(1, 'regcred')
rlQuestion.onCall(4).callsArgWith(1, 'dc94db56-asda-adssa-dada-123456789012')
rlQuestion.onCall(5).callsArgWith(1, 'bem-aad-sadad-123456789012')
rlQuestion.onCall(6).callsArgWith(1, 'dasdsd-1234-1234-1234-123456789012')
rlQuestion.onCall(7).callsArgWith(1, 'sdasd-4c4d-4d4d-4d4d-123456789012')
rlQuestion.onCall(8).callsArgWith(1, 'regcred')

cds.root = bookshop
await capOperatorPlugin('generate-runtime-values')
Expand Down Expand Up @@ -131,10 +132,11 @@ EXAMPLES
rlQuestion.onSecondCall().callsArgWith(1, '')
rlQuestion.onThirdCall().callsArgWith(1, 'c-abc.kyma.ondemand.com')
rlQuestion.onCall(3).callsArgWith(1, 'dc94db56-asda-adssa-dada-123456789012')
rlQuestion.onCall(4).callsArgWith(1, 'bem-aad-sadad-123456789012')
rlQuestion.onCall(5).callsArgWith(1, 'dasdsd-1234-1234-1234-123456789012')
rlQuestion.onCall(6).callsArgWith(1, 'sdasd-4c4d-4d4d-4d4d-123456789012')
rlQuestion.onCall(7).callsArgWith(1, 'regcred')
rlQuestion.onCall(4).callsArgWith(1, 'dc94db56-asda-adssa-dada-123456789012')
rlQuestion.onCall(5).callsArgWith(1, 'bem-aad-sadad-123456789012')
rlQuestion.onCall(6).callsArgWith(1, 'dasdsd-1234-1234-1234-123456789012')
rlQuestion.onCall(7).callsArgWith(1, 'sdasd-4c4d-4d4d-4d4d-123456789012')
rlQuestion.onCall(8).callsArgWith(1, 'regcred')

cds.root = bookshop
await capOperatorPlugin('generate-runtime-values')
Expand All @@ -157,8 +159,9 @@ EXAMPLES
rlQuestion.onSecondCall().callsArgWith(1, '')
rlQuestion.onThirdCall().callsArgWith(1, 'c-abc.kyma.ondemand.com')
rlQuestion.onCall(3).callsArgWith(1, 'dc94db56-asda-adssa-dada-123456789012')
rlQuestion.onCall(4).callsArgWith(1, 'sdasd-4c4d-4d4d-4d4d-123456789012')
rlQuestion.onCall(5).callsArgWith(1, 'regcred')
rlQuestion.onCall(4).callsArgWith(1, 'dc94db56-asda-adssa-dada-123456789012')
rlQuestion.onCall(5).callsArgWith(1, 'sdasd-4c4d-4d4d-4d4d-123456789012')
rlQuestion.onCall(6).callsArgWith(1, 'regcred')

cds.root = bookshop
await capOperatorPlugin('generate-runtime-values')
Expand Down Expand Up @@ -250,10 +253,11 @@ EXAMPLES
rlQuestion.onSecondCall().callsArgWith(1, '')
rlQuestion.onThirdCall().callsArgWith(1, 'c-abc.kyma.ondemand.com')
rlQuestion.onCall(3).callsArgWith(1, 'dc94db56-asda-adssa-dada-123456789012')
rlQuestion.onCall(4).callsArgWith(1, 'bem-aad-sadad-123456789012')
rlQuestion.onCall(5).callsArgWith(1, 'dasdsd-1234-1234-1234-123456789012')
rlQuestion.onCall(6).callsArgWith(1, 'sdasd-4c4d-4d4d-4d4d-123456789012')
rlQuestion.onCall(7).callsArgWith(1, 'regcred')
rlQuestion.onCall(4).callsArgWith(1, 'dc94db56-asda-adssa-dada-123456789012')
rlQuestion.onCall(5).callsArgWith(1, 'bem-aad-sadad-123456789012')
rlQuestion.onCall(6).callsArgWith(1, 'dasdsd-1234-1234-1234-123456789012')
rlQuestion.onCall(7).callsArgWith(1, 'sdasd-4c4d-4d4d-4d4d-123456789012')
rlQuestion.onCall(8).callsArgWith(1, 'regcred')

cds.root = bookshop
await capOperatorPlugin('generate-runtime-values')
Expand All @@ -277,10 +281,11 @@ EXAMPLES
rlQuestion.onSecondCall().callsArgWith(1, '')
rlQuestion.onThirdCall().callsArgWith(1, 'c-abc.kyma.ondemand.com')
rlQuestion.onCall(3).callsArgWith(1, 'dc94db56-asda-adssa-dada-123456789012')
rlQuestion.onCall(4).callsArgWith(1, 'bem-aad-sadad-123456789012')
rlQuestion.onCall(5).callsArgWith(1, 'dasdsd-1234-1234-1234-123456789012')
rlQuestion.onCall(6).callsArgWith(1, 'sdasd-4c4d-4d4d-4d4d-123456789012')
rlQuestion.onCall(7).callsArgWith(1, 'regcred')
rlQuestion.onCall(4).callsArgWith(1, 'dc94db56-asda-adssa-dada-123456789012')
rlQuestion.onCall(5).callsArgWith(1, 'bem-aad-sadad-123456789012')
rlQuestion.onCall(6).callsArgWith(1, 'dasdsd-1234-1234-1234-123456789012')
rlQuestion.onCall(7).callsArgWith(1, 'sdasd-4c4d-4d4d-4d4d-123456789012')
rlQuestion.onCall(8).callsArgWith(1, 'regcred')

cds.root = bookshop
await capOperatorPlugin('generate-runtime-values')
Expand All @@ -304,8 +309,9 @@ EXAMPLES
rlQuestion.onSecondCall().callsArgWith(1, '')
rlQuestion.onThirdCall().callsArgWith(1, 'c-abc.kyma.ondemand.com')
rlQuestion.onCall(3).callsArgWith(1, 'dc94db56-asda-adssa-dada-123456789012')
rlQuestion.onCall(4).callsArgWith(1, 'sdasd-4c4d-4d4d-4d4d-123456789012')
rlQuestion.onCall(5).callsArgWith(1, 'regcred')
rlQuestion.onCall(4).callsArgWith(1, 'dc94db56-asda-adssa-dada-123456789012')
rlQuestion.onCall(5).callsArgWith(1, 'sdasd-4c4d-4d4d-4d4d-123456789012')
rlQuestion.onCall(6).callsArgWith(1, 'regcred')

cds.root = bookshop
await capOperatorPlugin('generate-runtime-values')
Expand Down
1 change: 1 addition & 0 deletions test/files/expectedChart/runtime-values-ias.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ app:
app: istio-ingressgateway
btp:
globalAccountId: dc94db56-asda-adssa-dada-123456789012
providerSubaccountId: dc94db56-asda-adssa-dada-123456789012
provider:
subdomain: bem-aad-sadad-123456789012
tenantId: dasdsd-1234-1234-1234-123456789012
Expand Down
1 change: 1 addition & 0 deletions test/files/expectedChart/runtime-values-svc-ias.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ app:
app: istio-ingressgateway
btp:
globalAccountId: dc94db56-asda-adssa-dada-123456789012
providerSubaccountId: dc94db56-asda-adssa-dada-123456789012
imagePullSecrets:
- regcred
workloads:
Expand Down
1 change: 1 addition & 0 deletions test/files/expectedChart/runtime-values-svc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ app:
app: istio-ingressgateway
btp:
globalAccountId: dc94db56-asda-adssa-dada-123456789012
providerSubaccountId: dc94db56-asda-adssa-dada-123456789012
imagePullSecrets:
- regcred
workloads:
Expand Down
1 change: 1 addition & 0 deletions test/files/expectedChart/runtime-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ app:
app: istio-ingressgateway
btp:
globalAccountId: dc94db56-asda-adssa-dada-123456789012
providerSubaccountId: dc94db56-asda-adssa-dada-123456789012
provider:
subdomain: bem-aad-sadad-123456789012
tenantId: dasdsd-1234-1234-1234-123456789012
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ spec:
{{- end }}
btpAppName: {{ include "appName" $ }}
globalAccountId: {{ .Values.btp.globalAccountId }}
providerSubaccountId: {{ .Values.btp.providerSubaccountId }}
provider:
subDomain: {{ .Values.btp.provider.subdomain }}
tenantId: {{ .Values.btp.provider.tenantId }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ spec:
{{- end }}
btpAppName: {{ include "appName" $ }}
globalAccountId: {{ .Values.btp.globalAccountId }}
providerSubaccountId: {{ .Values.btp.providerSubaccountId }}
btp:
services:
{{- $serviceInstances := .Values.serviceInstances }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ spec:
{{- end }}
btpAppName: {{ include "appName" $ }}
globalAccountId: {{ .Values.btp.globalAccountId }}
providerSubaccountId: {{ .Values.btp.providerSubaccountId }}
btp:
services:
{{- $serviceInstances := .Values.serviceInstances }}
Expand Down
1 change: 1 addition & 0 deletions test/files/expectedChart/templates/cap-operator-cros.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ spec:
{{- end }}
btpAppName: {{ include "appName" $ }}
globalAccountId: {{ .Values.btp.globalAccountId }}
providerSubaccountId: {{ .Values.btp.providerSubaccountId }}
provider:
subDomain: {{ .Values.btp.provider.subdomain }}
tenantId: {{ .Values.btp.provider.tenantId }}
Expand Down
1 change: 1 addition & 0 deletions test/files/expectedChart/values-ias.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ app:
app: istio-ingressgateway
btp:
globalAccountId: null
providerSubaccountId: null
provider:
subdomain: null
tenantId: null
Expand Down
1 change: 1 addition & 0 deletions test/files/expectedChart/values-svc-ias.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ app:
app: istio-ingressgateway
btp:
globalAccountId: null
providerSubaccountId: null
imagePullSecrets: []
workloads:
server:
Expand Down
1 change: 1 addition & 0 deletions test/files/expectedChart/values-svc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ app:
app: istio-ingressgateway
btp:
globalAccountId: null
providerSubaccountId: null
imagePullSecrets: []
workloads:
server:
Expand Down
1 change: 1 addition & 0 deletions test/files/expectedChart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ app:
app: istio-ingressgateway
btp:
globalAccountId: null
providerSubaccountId: null
provider:
subdomain: null
tenantId: null
Expand Down
1 change: 1 addition & 0 deletions test/files/expectedChart/valuesWithDestination.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ app:
app: istio-ingressgateway
btp:
globalAccountId: null
providerSubaccountId: null
provider:
subdomain: null
tenantId: null
Expand Down
1 change: 1 addition & 0 deletions test/files/expectedChart/valuesWithMTA.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ app:
app: istio-ingressgateway
btp:
globalAccountId: null
providerSubaccountId: null
provider:
subdomain: null
tenantId: null
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ app:
app: istio-ingressgateway
btp:
globalAccountId: dc94db56-asda-adssa-dada-123456789012
providerSubaccountId: dc94db56-asda-adssa-dada-123456789012
provider:
subdomain: bem-aad-sadad-123456789012
tenantId: dasdsd-1234-1234-1234-123456789012
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ app:
app: istio-ingressgateway
btp:
globalAccountId: dc94db56-asda-adssa-dada-123456789012
providerSubaccountId: dc94db56-asda-adssa-dada-123456789012
imagePullSecrets:
- regcred
hanaInstanceId: sdasd-4c4d-4d4d-4d4d-123456789012
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ app:
app: istio-ingressgateway
btp:
globalAccountId: dc94db56-asda-adssa-dada-123456789012
providerSubaccountId: dc94db56-asda-adssa-dada-123456789012
provider:
subdomain: bem-aad-sadad-123456789012
tenantId: dasdsd-1234-1234-1234-123456789012
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ spec:
{{- end }}
btpAppName: {{ include "appName" $ }}
globalAccountId: {{ .Values.btp.globalAccountId }}
providerSubaccountId: {{ .Values.btp.providerSubaccountId }}
provider:
subDomain: {{ .Values.btp.provider.subdomain }}
tenantId: {{ .Values.btp.provider.tenantId }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ spec:
{{- end }}
btpAppName: {{ include "appName" $ }}
globalAccountId: {{ .Values.btp.globalAccountId }}
providerSubaccountId: {{ .Values.btp.providerSubaccountId }}
btp:
services:
{{- $serviceInstances := .Values.serviceInstances }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ spec:
{{- end }}
btpAppName: {{ include "appName" $ }}
globalAccountId: {{ .Values.btp.globalAccountId }}
providerSubaccountId: {{ .Values.btp.providerSubaccountId }}
provider:
subDomain: {{ .Values.btp.provider.subdomain }}
tenantId: {{ .Values.btp.provider.tenantId }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ spec:
{{- end }}
btpAppName: {{ include "appName" $ }}
globalAccountId: {{ .Values.btp.globalAccountId }}
providerSubaccountId: {{ .Values.btp.providerSubaccountId }}
provider:
subDomain: {{ .Values.btp.provider.subdomain }}
tenantId: {{ .Values.btp.provider.tenantId }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ spec:
{{- end }}
btpAppName: {{ include "appName" $ }}
globalAccountId: {{ .Values.btp.globalAccountId }}
providerSubaccountId: {{ .Values.btp.providerSubaccountId }}
btp:
services:
{{- $serviceInstances := .Values.serviceInstances }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ spec:
{{- end }}
btpAppName: {{ include "appName" $ }}
globalAccountId: {{ .Values.btp.globalAccountId }}
providerSubaccountId: {{ .Values.btp.providerSubaccountId }}
btp:
services:
{{- $serviceInstances := .Values.serviceInstances }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ spec:
{{- end }}
btpAppName: {{ include "appName" $ }}
globalAccountId: {{ .Values.btp.globalAccountId }}
providerSubaccountId: {{ .Values.btp.providerSubaccountId }}
provider:
subDomain: {{ .Values.btp.provider.subdomain }}
tenantId: {{ .Values.btp.provider.tenantId }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ app:
app: istio-ingressgateway
btp:
globalAccountId: null
providerSubaccountId: null
provider:
subdomain: null
tenantId: null
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ app:
app: istio-ingressgateway
btp:
globalAccountId: null
providerSubaccountId: null
imagePullSecrets: []
workloads:
server:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ app:
app: istio-ingressgateway
btp:
globalAccountId: null
providerSubaccountId: null
provider:
subdomain: null
tenantId: null
Expand Down
Loading
Loading