-
Notifications
You must be signed in to change notification settings - Fork 0
feat: MCPServerIdentity.connect(), ServerBadgeKeeper, stdio credential-in-_meta #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
10203e4
feat: MCPServerIdentity.connect(), ServerBadgeKeeper, stdio credentia…
beonde fb5f272
fix: correctly extract badge token from nested data.token response field
beonde 35a4066
fix: forward CAPISCIO_* env vars to stdio MCP server subprocess
beonde 839d73e
feat: env var key injection for ephemeral environments (CAPISCIO_SERV…
beonde c9c3abc
docs: add deployment guide and document env var key injection
beonde 646d9fa
fix(docs): correct did:key → did:web for production registry usage
beonde b0b457d
fix: address Copilot PR review comments
beonde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "Deploying to Containers / Serverless" section describes a flow where the SDK logs the full PEM-encoded server private key so it can be copied into
CAPISCIO_SERVER_PRIVATE_KEY_PEM. Emitting a long‑term private key in cleartext logs is dangerous, because log streams are often aggregated and broadly accessible, allowing anyone with log access to recover the key and impersonate the MCP server. The recommended flow should avoid logging private keys entirely and instead rely on a more controlled key export mechanism or non-sensitive fingerprints, and the documentation should be updated to stop encouraging copying keys from logs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the deployment.md thread — the code now uses
print(file=sys.stderr)instead oflogger.warning(), preventing the PEM from entering log aggregation. The capture hint is a deliberate first-run-only operator UX for local terminal sessions. See commit b0b457d.