Fix up KeySpace tasks to use the supplied config#19
Open
bossmc wants to merge 1 commit intocarbonfive:masterfrom
Open
Fix up KeySpace tasks to use the supplied config#19bossmc wants to merge 1 commit intocarbonfive:masterfrom
bossmc wants to merge 1 commit intocarbonfive:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment in the code explains the fix, YAML returns the config hash as String=>Value, but when working out the settings for the KeySpace creation task, you merge it with a has that is Symbol=>Value.
This fix ensures that we always use the Symbol=>Value version (which is what the Cassandra gem wants as well).
I needed this fix to get the 0.2 version of your gem to work with Cassandra 1.1 where LocalStrategy is no longer allowed. The other thing I had to change was to use:
Since Cassandra 1.1 no longer lets you pass the replication factor in on it's own, it has to be embedded in the
strategy_optionshash...