This repository was archived by the owner on Jan 12, 2019. It is now read-only.
Use HTTPS URL for submodule to allow read access for non GH users#90
Open
Johennes wants to merge 1 commit intocard-io:masterfrom
Open
Use HTTPS URL for submodule to allow read access for non GH users#90Johennes wants to merge 1 commit intocard-io:masterfrom
Johennes wants to merge 1 commit intocard-io:masterfrom
Conversation
This is required to be able to clone the repository and its submodules without having a GitHub account. An example use case is consuming card.io through carthage to build an iOS application within a large team of engineers where people simply cannot be required to sign up for GitHub and upload their SSH key just to build the app. See also Carthage/Carthage#1865
lkorth
approved these changes
Apr 5, 2017
Member
|
Thanks for the pull request. This has been discussed fairly extensively in the past, but my search fu is failing me. There are benefits to both ssh and https. If you need https, you can use git's insteadof support: https://stackoverflow.com/questions/1722807/git-convert-git-urls-to-http-urls. |
Author
|
Thanks for the pointer. So putting this into my global indeed makes card.io work with carthage. I still think it would be nice if no additional setup was required just for consuming the framework but I'm fine with this if SSH brings benefits in other use cases. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to be able to clone the repository and its submodules without having a GitHub account. An example use case is consuming card.io through carthage to build an iOS application within a large team of engineers where people simply cannot be required to sign up for GitHub and upload their SSH key just to build the app.
See also Carthage/Carthage#1865