fix: don't poison cached sync status on transient DB pool contention#772
Draft
Sotatek-HenryDo wants to merge 1 commit into
Draft
fix: don't poison cached sync status on transient DB pool contention#772Sotatek-HenryDo wants to merge 1 commit into
Sotatek-HenryDo wants to merge 1 commit into
Conversation
SyncStatusService.refreshSyncStatus() runs on a background scheduler thread that shares HikariCP's fixed-size pool with request-serving threads. Under heavy load, PostgreSQLIndexCreationMonitor.isCreatingIndexes() silently swallowed pool contention/timeout errors and returned a safe "not ready" default - which refreshSyncStatus() then wrote into the single cachedSyncStatus shared by every concurrent request, failing all of them for up to a full refresh interval even though the indexer was actually healthy. Add IndexCreationMonitor.isCreatingIndexesOrThrow(), a variant that propagates the exception instead of swallowing it. refreshSyncStatus() now uses it (and catches around the whole refresh, including the latest-block lookup) so a transient failure just leaves the last known-good cached status in place instead of overwriting it with a false negative. isCreatingIndexes()'s existing swallow-and-default behavior is unchanged for its other caller (SyncStatusHealthIndicator). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
✅ Preprod Tests: PASSEDTests run against preprod network with live blockchain data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SyncStatusService.refreshSyncStatus() runs on a background scheduler thread that shares HikariCP's fixed-size pool with request-serving threads. Under heavy load, PostgreSQLIndexCreationMonitor.isCreatingIndexes() silently swallowed pool contention/timeout errors and returned a safe "not ready" default - which refreshSyncStatus() then wrote into the single cachedSyncStatus shared by every concurrent request, failing all of them for up to a full refresh interval even though the indexer was actually healthy.
Add IndexCreationMonitor.isCreatingIndexesOrThrow(), a variant that propagates the exception instead of swallowing it. refreshSyncStatus() now uses it (and catches around the whole refresh, including the latest-block lookup) so a transient failure just leaves the last known-good cached status in place instead of overwriting it with a false negative. isCreatingIndexes()'s existing swallow-and-default behavior is unchanged for its other caller (SyncStatusHealthIndicator).