Revert sync-status gating/caching/scheduler (#758, #761, #767)#773
Merged
Conversation
Reverts: - 2cb7b1f fix: block data endpoints when indexer is syncing (#758) - e95fb74 feat: add 5s cache for sync status verification (#761) - 990564b feat(sync) status refresh scheduler (#767) These introduced verifySyncStatus() gating on /account/balance, /account/coins, and /search, later backed by a periodic @scheduled background refresh sharing the Hikari connection pool with request traffic. Under load, a transient DB timeout in the scheduled refresh gets swallowed by PostgreSQLIndexCreationMonitor's defensive exception handling and poisons the single shared cached status for up to 10s, causing a step-function error spike across all gated endpoints (e.g. 37.51% error rate on /account/balance at concurrency 24, 87.78% on /account/coins at concurrency 44). This revert isolates the legacy stability test from that regression to confirm the root cause before deciding on a permanent fix.
Contributor
✅ Preprod Tests: PASSEDTests run against preprod network with live blockchain data |
Sotatek-HenryDo
marked this pull request as ready for review
July 16, 2026 10:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts:
These introduced verifySyncStatus() gating on /account/balance, /account/coins, and /search, later backed by a periodic @scheduled background refresh sharing the Hikari connection pool with request traffic. Under load, a transient DB timeout in the scheduled refresh gets swallowed by PostgreSQLIndexCreationMonitor's defensive exception handling and poisons the single shared cached status for up to 10s, causing a step-function error spike across all gated endpoints (e.g. 37.51% error rate on /account/balance at concurrency 24, 87.78% on /account/coins at concurrency 44).
This revert isolates the legacy stability test from that regression to confirm the root cause before deciding on a permanent fix.