Skip to content

Fix stale isolated markup for public realm in operator mode#4246

Merged
burieberry merged 2 commits intomainfrom
cs-10204-duplicate-markup
Mar 26, 2026
Merged

Fix stale isolated markup for public realm in operator mode#4246
burieberry merged 2 commits intomainfrom
cs-10204-duplicate-markup

Conversation

@burieberry
Copy link
Contributor

removeIsolatedMarkup — the modifier that cleans up SSR-prerendered HTML — only fires in Host Mode. This is why on operator mode, on staging and prod we see duplicate markup for the homepage-realm when https://realms-staging.stack.cards/boxel-homepage route is visited (prerendered one remains behind the operator mode rendering).

We accidentally realized this issue in homepage-realm because of the z-index on the navbar and because homepage-realm hidden from workspace chooser. In fact, we can see this in other public realms too when directly visited. For example, here's https://realms-staging.stack.cards/skills :
skills-staging

@burieberry burieberry marked this pull request as ready for review March 25, 2026 20:57
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d3710533ac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions
Copy link

Preview deployments

@github-actions
Copy link

Host Test Results

    1 files  ±0      1 suites  ±0   2h 10m 58s ⏱️ + 2m 19s
2 051 tests ±0  2 036 ✅ ±0  15 💤 ±0  0 ❌ ±0 
2 066 runs  ±0  2 051 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit 28d5be9. ± Comparison against base commit 0900ac6.

@burieberry burieberry requested a review from a team March 25, 2026 21:57
@burieberry burieberry merged commit 1956260 into main Mar 26, 2026
118 of 119 checks passed
@burieberry burieberry deleted the cs-10204-duplicate-markup branch March 26, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants