bin/lesson_check.py: allow exceptions to line length limit#594
Conversation
Allow lines that contain a single image or a single link to go over the suggested line length limit.
ab46307 to
0f1cec8
Compare
|
Thanks Maxim! |
|
Thanks, François! @jhlegarreta, could you please confirm that after this change |
|
The regex does not seem straightforward ! Thanks both 👍.
Will give it a try when I find the time (will try during the weekend) and will report back. |
|
Unfortunately, it does not look like it solved the issue. In fact, the number of warnings has increased, e.g.: In the previous version, link-only lines (e.g. line 190 at the pointed file - |
|
Oh, I see what the problem is. The pattern I added doesn't allow |
|
So, I found a few things that you use in your lesson that I didn't take into account when I was working on this pattern:
So, #597 should address all of these. |
Allow lines that contain a single image or a single link to go over the suggested line length limit. So, all of the following lines will be allowed to go over the line limit:
Plus all of the above prefixed with any combination of
>andto allow these lines to go over the limit in various code blocks.Fixes #591