Merged
Conversation
|
@Lun4m What's your use case for this feature? I don't see a comment from you in the linked issue. This seems compatible with #2682 but there will be merge conflicts and it will be important we have good test cases for both features For what it's worth, if this config option does get added, I think |
Owner
|
Seems reasonable to me! I notice that the original issue has eight thumbs up, so it seems like something people want. I made some changes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #733
It's maybe too naive? I added some basic tests, but can you think of other edge cases I should test?
I also need to add some documentation I guess.