Skip to content

Fix completed backfills not showing 100% progress#550

Open
petera-block wants to merge 1 commit intocashapp:masterfrom
petera-block:petera/fix-completed-backfill-progress
Open

Fix completed backfills not showing 100% progress#550
petera-block wants to merge 1 commit intocashapp:masterfrom
petera-block:petera/fix-completed-backfill-progress

Conversation

@petera-block
Copy link
Copy Markdown

Summary

  • Backfills with state COMPLETE could show less than 100% progress when the backfilled count didn't exactly match the computed count
  • Clamp ProgressBar percentage to 0–100% via .coerceIn(0.0, 100.0)
  • Override progress to 100% on both the backfill detail page and the backfills list table when state is COMPLETE

Test plan

  • ./gradlew :service:build passes
  • Verify on a completed backfill (e.g. #38168) that progress now shows 100%
  • Verify in-progress and paused backfills still show accurate partial progress

🤖 Generated with Claude Code

Backfills with state COMPLETE could show less than 100% progress when
the backfilled count didn't exactly match the computed count. This
clamps the progress bar percentage and overrides to 100% when the
backfill state is COMPLETE.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants