Add ignoredServices to DuplicateRegistrationDetector#311
Closed
skorulis-ap wants to merge 1 commit intomainfrom
Closed
Add ignoredServices to DuplicateRegistrationDetector#311skorulis-ap wants to merge 1 commit intomainfrom
skorulis-ap wants to merge 1 commit intomainfrom
Conversation
bradfol
reviewed
Oct 28, 2025
|
|
||
| public init( | ||
| ignoredServices: [Any.Type] = [], | ||
| duplicateWasDetected: ((Key) -> Void)? = nil |
Contributor
There was a problem hiding this comment.
The detector currently keeps all duplicates on the detectedKeys array. Right now cash-ios is just checking duplicateDetection.detectedKeys.isEmpty but we could be ignoring keys from that list with the existing APIs. Thoughts?
Contributor
Author
There was a problem hiding this comment.
That works. Will close this PR and do it that way
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows
DuplicateRegistrationDetectorto be run in some CI tests to prevent anything slipping into main.