Convert SwinjectContainer generated argument registration functions to use parameter packs#314
Merged
skorulis-ap merged 1 commit intomainfrom Feb 18, 2026
Merged
Conversation
skorulis-ap
force-pushed
the
skorulis/parameter-packs-17
branch
from
6063a9c to
af03d69
Compare
…o use parameter packs
skorulis-ap
force-pushed
the
skorulis/parameter-packs-17
branch
from
af03d69 to
b81a4d4
Compare
bradfol
approved these changes
Feb 18, 2026
| /// and returns the instance of the component type for the service. | ||
| /// | ||
| /// - Returns: A registered `ServiceEntry` to configure more settings with method chaining. | ||
| @discardableResult public func register<Service, FirstArgument, each ArgumentType>( |
Contributor
There was a problem hiding this comment.
Curious why is FirstArgument declared separately from the rest of the parameter pack?
Contributor
Author
There was a problem hiding this comment.
It's so the empty argument case still goes through the existing function without arguments. It might be possible to consolidate them, but I think I hit issues when trying that last time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only does the first part of the migration to parameter packs as an experiment. I'm not seeing the same issues that I ran into last time.
I'll follow up this PR with one that migrates the rest of the ERB templates to parameter packs.
Tested using this branch in cash-ios with no issues: https://github.com/squareup/cash-ios/pull/77758