Feature: add --json flag to app.py for machine-readable slot diff output#511
Open
casks-mutters wants to merge 1 commit intomainfrom
Open
Feature: add --json flag to app.py for machine-readable slot diff output#511casks-mutters wants to merge 1 commit intomainfrom
casks-mutters wants to merge 1 commit intomainfrom
Conversation
## Summary
`app.py` currently prints results in a human-readable format only.
For scripting, automation, CI pipelines, dashboards, or data ingestion, it would be extremely helpful to have a JSON output option.
This PR adds a `--json` flag so callers can request structured output describing:
- the slot value at block A
- the slot value at block B
- whether they differ
- the pair commitment emitted
- all arguments (address, slot, block numbers)
## Proposed Changes
- Add a `--json` boolean flag to `argparse`.
- After computing:
- `value_a`
- `value_b`
- the hex commitment (`pair_hex`)
- If `--json` is set:
- print a JSON object with keys:
- `address`
- `slot`
- `block_a`
- `block_b`
- `value_a`
- `value_b`
- `changed` (bool)
- `commitment_hex`
- then exit without printing the human-readable summary.
## Example Output
```json
{
"address": "0x1234...",
"slot": "0x0",
"block_a": 18000000,
"block_b": 18000010,
"value_a": "0x0000...",
"value_b": "0x0000...",
"changed": false,
"commitment_hex": "0xabc123..."
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.pycurrently prints results in a human-readable format only. For scripting, automation, CI pipelines, dashboards, or data ingestion, it would be extremely helpful to have a JSON output option.This PR adds a
--jsonflag so callers can request structured output describing:Proposed Changes
--jsonboolean flag toargparse.value_avalue_bpair_hex)--jsonis set:addressslotblock_ablock_bvalue_avalue_bchanged(bool)commitment_hexExample Output
{ "address": "0x1234...", "slot": "0x0", "block_a": 18000000, "block_b": 18000010, "value_a": "0x0000...", "value_b": "0x0000...", "changed": false, "commitment_hex": "0xabc123..." }