Test: add unit tests for leaf_commitment and pair_root functions#514
Open
casks-mutters wants to merge 1 commit intomainfrom
Open
Test: add unit tests for leaf_commitment and pair_root functions#514casks-mutters wants to merge 1 commit intomainfrom
casks-mutters wants to merge 1 commit intomainfrom
Conversation
## Summary Currently, there are no tests for the `leaf_commitment` and `pair_root` functions. Adding tests will help ensure the correctness of these core functions. ## Proposed Changes - Create a new `tests/` directory. - Add unit tests for: - `leaf_commitment`: check that the correct commitment is returned for a given slot, address, and block. - `pair_root`: verify that it correctly computes the root from two leaf values. ## Motivation - Provides confidence that the core cryptographic functions behave as expected. - Helps detect regressions or incorrect changes in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, there are no tests for the
leaf_commitmentandpair_rootfunctions. Adding tests will help ensure the correctness of these core functions.Proposed Changes
tests/directory.leaf_commitment: check that the correct commitment is returned for a given slot, address, and block.pair_root: verify that it correctly computes the root from two leaf values.Motivation