Pre release fixes

knex/migrations/20251109095712_remove_orphan_mentor_role.js

@@ -0,0 +1,33 @@
+/**
+ * @param { import("knex").Knex } knex
+ * @returns { Promise<void> }
+ */
+exports.up = async function(knex) {
+  return knex.transaction(async (trx) => {
+    const mentorRole = await trx('roles').where({ role_name: 'mentor' }).first();
+
+    if (!mentorRole) {
+      console.warn('Mentor role not found — skipping cleanup.');
+      return;
+    }
+
+    await trx('user_roles')
+      .where('role_id', mentorRole.id)
+      .whereIn('user_id', function () {
+        this.select('user_id')
+          .from('user_roles')
+          .where('role_id', mentorRole.id)
+          .whereNotIn('user_id', trx('mentors').select('user_id'));
+      })
+      .del();
+  });
+};
+
+/**
+ * @param { import("knex").Knex } knex
+ * @returns { Promise<void> }
+ */
+exports.down = async function(_) {
+  // This migration is not reversible because deleted rows cannot be recovered.
+  console.warn('⚠️  This migration is not reversible (cannot recover deleted rows)');
+};

services/mentor_service.js

@@ -40,7 +40,6 @@ async function createMentor(userId, mentorData) {
     status: 'pending',
     about: mentorData.about,
     contact: mentorData.contact,
-    tags: mentorData.tags
   };
 
   const mentorInfo = await repo.createMentor(mentor);

tests/services/mentor_service.test.js

@@ -36,8 +36,7 @@ describe('Mentor Service', () => {
         user_id: defaultUserId,
         status: MENTOR_STATUSES.pending,
         about: mentorData.about,
-        contact: mentorData.contact,
-        tags: mentorData.tags
+        contact: mentorData.contact
       });
       expect(tagsRepo.updateMentorTags).toHaveBeenCalledWith(createdMentor.id, mentorData.tags);
       expect(rolesService.getAdminEmails).toHaveBeenCalled();