remove unused functionality#4
Open
jhunsaker wants to merge 15 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
These mutex types are unused by the top-level project. Removes source files, headers, and references from CMakeLists.txt and all.hpp. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Unused by the top-level project. Removes source, header, examples, and performance benchmarks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Unused by the top-level project. Removes source, header, examples, and performance benchmarks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Unused by the top-level project. Removes header, example, and include references from fiber.hpp and all.hpp. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Unused by the top-level project. Removes source, header, dedicated test files, and dead do_wait() references in fiber tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Unused by the top-level project. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Unused by the top-level project. Removes fss.hpp, detail/fss.hpp, test files, and cleans fss_data_ from context.hpp and context.cpp. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Unused by the top-level project. Removes header, test files, and examples that solely used unbuffered_channel. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Unused by the top-level project. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Unused by the top-level project. Removes rtm.hpp, spinlock_rtm.hpp, and strips BOOST_USE_TSX branches from spinlock.hpp. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Removes the sleep queue from the scheduler (sleep2ready_, wait_until, sleep_hook, sleep_waker_, tp_), and all timed-wait variants from condition_variable, buffered_channel, future, and operations.hpp. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR removes a large set of previously supported (or example/tested) Boost.Fiber features, especially timed-wait APIs and a number of auxiliary components (barrier, fiber-specific storage, timed/recursive mutex variants, additional schedulers, GPU helpers, benchmarks, and examples). It also simplifies the scheduler/algorithm interface to no longer support timepoint-based suspension.
Changes:
- Remove timed-wait-related APIs across futures, condition variables, channels, scheduler, and
this_fiberoperations. - Remove multiple library components (barrier, timed/recursive mutexes, FSS, shared_work/work_stealing schedulers, TSX/RTM spinlock support) along with associated tests, examples, and performance benchmarks.
- Update
algo::algorithm/round_robinand the core scheduler to use a non-timedsuspend()mechanism.
Reviewed changes
Copilot reviewed 96 out of 96 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/test_shared_future_post.cpp | Drops shared_future timed-wait tests/helpers |
| test/test_shared_future_dispatch.cpp | Drops shared_future timed-wait tests/helpers |
| test/test_mutex_mt_post.cpp | Removes recursive/timed mutex tests; minor comment cleanup |
| test/test_mutex_mt_dispatch.cpp | Removes recursive/timed mutex tests; minor comment cleanup |
| test/test_future_post.cpp | Drops future timed-wait tests/helpers |
| test/test_future_dispatch.cpp | Drops future timed-wait tests/helpers |
| test/test_fss_post.cpp | Removes FSS test suite (file deleted) |
| test/test_fss_dispatch.cpp | Removes FSS test suite (file deleted) |
| test/test_fiber_post.cpp | Removes sleep/detach-related tests |
| test/test_fiber_dispatch.cpp | Removes sleep/detach-related tests |
| test/test_condition_variable_any_post.cpp | Removes timed wait_* condition_variable_any tests/helpers |
| test/test_buffered_channel_post.cpp | Removes timed push/pop channel tests/helpers |
| test/test_buffered_channel_dispatch.cpp | Removes timed push/pop channel tests/helpers |
| test/test_barrier_post.cpp | Removes barrier test suite (file deleted) |
| test/test_barrier_dispatch.cpp | Removes barrier test suite (file deleted) |
| src/waker.cpp | Removes wait-queue timed suspend helper |
| src/timed_mutex.cpp | Removes timed_mutex implementation (file deleted) |
| src/scheduler.cpp | Removes sleep-queue/timepoint suspension; uses algo_->suspend() |
| src/recursive_timed_mutex.cpp | Removes recursive_timed_mutex implementation (file deleted) |
| src/recursive_mutex.cpp | Removes recursive_mutex implementation (file deleted) |
| src/context.cpp | Removes sleep hooks, wait_until, and FSS storage/cleanup |
| src/barrier.cpp | Removes barrier implementation (file deleted) |
| src/algo/work_stealing.cpp | Removes work_stealing scheduler impl (file deleted) |
| src/algo/shared_work.cpp | Removes shared_work scheduler impl (file deleted) |
| src/algo/round_robin.cpp | Updates round_robin to implement suspend() |
| performance/thread/skynet_std.cpp | Removes thread skynet benchmark (file deleted) |
| performance/thread/skynet_pthread.cpp | Removes pthread skynet benchmark (file deleted) |
| performance/thread/skynet_async.cpp | Removes async skynet benchmark (file deleted) |
| performance/thread/Jamfile.v2 | Removes thread benchmark build file (file deleted) |
| performance/thread/buffered_channel.hpp | Removes benchmark helper channel (file deleted) |
| performance/fiber/skynet_stealing_join.cpp | Removes fiber benchmark (file deleted) |
| performance/fiber/skynet_stealing_detach.cpp | Removes fiber benchmark (file deleted) |
| performance/fiber/skynet_stealing_async.cpp | Removes fiber benchmark (file deleted) |
| performance/fiber/skynet_shared_join.cpp | Removes fiber benchmark (file deleted) |
| performance/fiber/skynet_shared_detach.cpp | Removes fiber benchmark (file deleted) |
| performance/fiber/skynet_join.cpp | Removes fiber benchmark (file deleted) |
| performance/fiber/skynet_detach.cpp | Removes fiber benchmark (file deleted) |
| performance/fiber/Jamfile.v2 | Removes fiber benchmark build file (file deleted) |
| performance/fiber/barrier.hpp | Removes benchmark barrier helper (file deleted) |
| performance/clock.hpp | Removes benchmark clock helper (file deleted) |
| include/boost/fiber/waker.hpp | Removes timed suspend API from wait_queue |
| include/boost/fiber/type.hpp | Removes FSS detail include dependency |
| include/boost/fiber/timed_mutex.hpp | Removes timed_mutex public header (file deleted) |
| include/boost/fiber/segmented_stack.hpp | Removes segmented_stack header (file deleted) |
| include/boost/fiber/scheduler.hpp | Removes sleep-queue/timepoint APIs and types |
| include/boost/fiber/recursive_timed_mutex.hpp | Removes recursive_timed_mutex header (file deleted) |
| include/boost/fiber/recursive_mutex.hpp | Removes recursive_mutex header (file deleted) |
| include/boost/fiber/pooled_fixedsize_stack.hpp | Removes pooled_fixedsize_stack alias header (file deleted) |
| include/boost/fiber/operations.hpp | Removes this_fiber::sleep_for/sleep_until APIs |
| include/boost/fiber/hip/waitfor.hpp | Removes HIP waitfor helper header (file deleted) |
| include/boost/fiber/future/future.hpp | Removes future/shared_future timed wait_for/until APIs |
| include/boost/fiber/future/detail/shared_state.hpp | Removes shared_state timed wait implementations |
| include/boost/fiber/fss.hpp | Removes fiber-specific storage API (file deleted) |
| include/boost/fiber/fiber.hpp | Removes segmented_stack include |
| include/boost/fiber/detail/thread_barrier.hpp | Removes thread_barrier helper (file deleted) |
| include/boost/fiber/detail/spinlock.hpp | Removes TSX/RTM spinlock integration |
| include/boost/fiber/detail/spinlock_rtm.hpp | Removes RTM spinlock header (file deleted) |
| include/boost/fiber/detail/rtm.hpp | Removes RTM intrinsics wrapper (file deleted) |
| include/boost/fiber/detail/fss.hpp | Removes FSS cleanup-function detail header (file deleted) |
| include/boost/fiber/cuda/waitfor.hpp | Removes CUDA waitfor helper header (file deleted) |
| include/boost/fiber/context.hpp | Removes sleep hooks, timepoints, and FSS APIs from context |
| include/boost/fiber/condition_variable.hpp | Removes timed wait_for/wait_until APIs |
| include/boost/fiber/buffered_channel.hpp | Removes timed push/pop APIs |
| include/boost/fiber/barrier.hpp | Removes barrier public header (file deleted) |
| include/boost/fiber/all.hpp | Stops including removed components (barrier/FSS/etc.) |
| include/boost/fiber/algo/work_stealing.hpp | Removes work_stealing public header (file deleted) |
| include/boost/fiber/algo/shared_work.hpp | Removes shared_work public header (file deleted) |
| include/boost/fiber/algo/round_robin.hpp | Updates algorithm interface to suspend() |
| include/boost/fiber/algo/algorithm.hpp | Changes base algorithm interface to suspend() |
| examples/work_stealing.cpp | Removes example (file deleted) |
| examples/work_sharing.cpp | Removes example (file deleted) |
| examples/segmented_stack.cpp | Removes example (file deleted) |
| examples/range_for.cpp | Removes example (file deleted) |
| examples/hip/single_stream.cpp | Removes example (file deleted) |
| examples/hip/multiple_streams.cpp | Removes example (file deleted) |
| examples/hip/Makefile | Removes example build file (file deleted) |
| examples/cuda/single_stream.cu | Removes example (file deleted) |
| examples/cuda/multiple_streams.cu | Removes example (file deleted) |
| examples/cuda/Makefile | Removes example build file (file deleted) |
| examples/asio/yield.hpp | Removes example header (file deleted) |
| examples/asio/round_robin.hpp | Removes example scheduler (file deleted) |
| examples/asio/ps/subscriber.cpp | Removes example (file deleted) |
| examples/asio/ps/publisher.cpp | Removes example (file deleted) |
| examples/asio/exchange.cpp | Removes example (file deleted) |
| examples/asio/autoecho.cpp | Removes example (file deleted) |
| CMakeLists.txt | Removes deleted sources from CMake target |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
39
to
47
| virtual void awakened( context *) noexcept = 0; | ||
|
|
||
| virtual context * pick_next() noexcept = 0; | ||
|
|
||
| virtual bool has_ready_fibers() const noexcept = 0; | ||
|
|
||
| virtual void suspend_until( std::chrono::steady_clock::time_point const&) noexcept = 0; | ||
| virtual void suspend() noexcept = 0; | ||
|
|
||
| virtual void notify() noexcept = 0; |
Comment on lines
+9
to
16
| #include <boost/config.hpp> | ||
|
|
||
| #include <boost/fiber/algo/algorithm.hpp> | ||
| #include <boost/fiber/context.hpp> | ||
| #include <boost/fiber/detail/config.hpp> | ||
| #include <boost/fiber/detail/convert.hpp> | ||
| #include <boost/fiber/fiber.hpp> | ||
| #include <boost/fiber/scheduler.hpp> | ||
|
|
Comment on lines
10
to
14
| #include <boost/fiber/algo/algorithm.hpp> | ||
| #include <boost/fiber/algo/round_robin.hpp> | ||
| #include <boost/fiber/algo/shared_work.hpp> | ||
| #include <boost/fiber/algo/work_stealing.hpp> | ||
| #include <boost/fiber/barrier.hpp> | ||
| #include <boost/fiber/buffered_channel.hpp> | ||
| #include <boost/fiber/channel_op_status.hpp> | ||
| #include <boost/fiber/condition_variable.hpp> |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.