Skip to content

fix: missing variables#82

Open
ninetailedtori wants to merge 2 commits into
catppuccin:mainfrom
ninetailedtori:colored-elems-and-misc
Open

fix: missing variables#82
ninetailedtori wants to merge 2 commits into
catppuccin:mainfrom
ninetailedtori:colored-elems-and-misc

Conversation

@ninetailedtori

Copy link
Copy Markdown
  • text was equal to background on colored elements, fixed it now
  • missing ansi colors
  • missing some miscellaneous keys
  • missing console colors

@ninetailedtori ninetailedtori changed the title fixes: misc fix: (missing variables) Feb 21, 2026
@ninetailedtori ninetailedtori changed the title fix: (missing variables) fix: missing variables Feb 21, 2026

@koibtw koibtw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it would be better to separate actual color changes from this pr and keep only the missing variables here

Comment thread src/_theme.scss Outdated
@ninetailedtori

Copy link
Copy Markdown
Author

i think it would be better to separate actual color changes from this pr and keep only the missing variables here

That's a good idea tbh! I'm just not sure how to neatly separate PRs ;w; if I could cherry pick specific lines/hunks of commits and rewrite history to separate to a different branch...

@koibtw

koibtw commented Mar 8, 2026 via email

Copy link
Copy Markdown
Member

@ninetailedtori

Copy link
Copy Markdown
Author

alright, I'm going to separate it today!

@ninetailedtori ninetailedtori force-pushed the colored-elems-and-misc branch from db75ff2 to 1f7aef6 Compare April 24, 2026 15:43
@ninetailedtori ninetailedtori requested a review from koibtw April 24, 2026 15:44

@koibtw koibtw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Comment thread src/_theme.scss
Comment on lines +109 to +124
@function ansibright($color) {
@if isDark {
@return oklch(
calc(lightness($color) * 0.94)
calc(saturation($color) + 8)
calc(hue($color) + 2deg)
);
}
@else {
@return oklch(
calc(lightness($color) * 1.09)
saturation($color)
calc(hue($color) + 2deg)
);
}
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably get the ANSI colors from the palette, let me work on that rq.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once that gets handled, feel free to edit the branch or toss the diff as a review to quick-merge.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgoudham

Copy link
Copy Markdown
Contributor

Can you paste some screenshots before/after this PR?

@ninetailedtori

Copy link
Copy Markdown
Author

Can you paste some screenshots before/after this PR?

One sec, yea lemme grab that.

@ninetailedtori ninetailedtori force-pushed the colored-elems-and-misc branch 2 times, most recently from a2102f1 to fe1b94b Compare April 26, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants