Skip to content

fix(desmos): landing announcement, additional pages, login modal#2159

Open
scarcekoi wants to merge 23 commits intocatppuccin:mainfrom
scarcekoi:add-desmos-testing
Open

fix(desmos): landing announcement, additional pages, login modal#2159
scarcekoi wants to merge 23 commits intocatppuccin:mainfrom
scarcekoi:add-desmos-testing

Conversation

@scarcekoi
Copy link
Copy Markdown
Member

@scarcekoi scarcekoi commented Mar 9, 2026 •
edited
Loading

🔧 What does this fix? 🔧

Fixes unthemed header on Desmos testing pages.
Fixes unthemed announcement banner on main page.
Fixes partially themed log in page.

🗒 Checklist 🗒

@scarcekoi scarcekoi requested a review from gradylink as a code owner March 9, 2026 20:15
@github-actions github-actions bot added the desmos Desmos label Mar 9, 2026
gradylink
gradylink previously approved these changes Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gradylink gradylink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@uncenter
Copy link
Copy Markdown
Member

uncenter commented Mar 10, 2026

Is there a reproduction URL for this I can look at?

@scarcekoi
Copy link
Copy Markdown
Member Author

scarcekoi commented Mar 10, 2026

Is there a reproduction URL for this I can look at?

https://www.desmos.com/testing/collegeboard/scientific

uncenter
uncenter reviewed Mar 11, 2026
View reviewed changes
Comment thread styles/desmos/catppuccin.user.less Outdated
uncenter
uncenter reviewed Mar 11, 2026
View reviewed changes
Comment thread styles/desmos/catppuccin.user.less Outdated
@uncenter
Copy link
Copy Markdown
Member

uncenter commented Mar 11, 2026

Is it possible that instead of making a new moz-documents url rule for this, this could just be added to the main moz-document (nested under .spa-sample-calculator-view maybe) with a comment?

@scarcekoi @uncenter
style(desmos): green to accent
116806d 
Co-authored-by: uncenter <uncenter@uncenter.dev>
@scarcekoi @uncenter
refactor(desmos): remove non-colour chsnges
75f734d 
Co-authored-by: uncenter <uncenter@uncenter.dev>
@scarcekoi scarcekoi changed the title fix(desmos): add desmos testing page header fix(desmos): add testing page header Mar 11, 2026
@scarcekoi
Copy link
Copy Markdown
Member Author

scarcekoi commented Mar 11, 2026 •
edited
Loading

Is it possible that instead of making a new moz-documents url rule for this, this could just be added to the main moz-document (nested under .spa-sample-calculator-view maybe) with a comment?

I did it in a new moz-document because it needs to change the colour of the desmos logo which when I tried theming it in the main moz-document, it was overriden by the !important on the original logo theming but it worked in a new moz-document.

@uncenter
Copy link
Copy Markdown
Member

uncenter commented Mar 11, 2026

Moving the styles in the new moz-document to the bottom of the existing one seems to have no issues for me. Have you tried it?

@scarcekoi
fix(desmos): theme frontpage landing announcement
61fb932 
Theme the frontpage landing announcement.
Remove the second moz-document and move the style changes inside to the
bottom of the first moz-document.
@scarcekoi scarcekoi changed the title fix(desmos): add testing page header fix(desmos): add testing page header and landing page announcement Mar 11, 2026
uncenter
uncenter reviewed Mar 11, 2026
View reviewed changes
Comment thread styles/desmos/catppuccin.user.less Outdated
scarcekoi and others added 2 commits March 11, 2026 15:25
@scarcekoi @uncenter
fix(desmos): use fade instead of rgba
d670eb5 
Co-authored-by: uncenter <uncenter@uncenter.dev>
@scarcekoi
feat(desmos): theme log in modal
6225283 
Closes: catppuccin#2165
@scarcekoi scarcekoi changed the title fix(desmos): add testing page header and landing page announcement fix(desmos): misc Mar 11, 2026
@uncenter uncenter linked an issue Mar 11, 2026 that may be closed by this pull request
Desmos: Sign Up/Log In Page Partially Unthemed #2165
Open
2 tasks
uncenter
uncenter reviewed Mar 11, 2026
View reviewed changes
Comment thread styles/desmos/catppuccin.user.less
uncenter
uncenter reviewed Mar 11, 2026
View reviewed changes
Comment thread styles/desmos/catppuccin.user.less Outdated
@WalkQuackBack WalkQuackBack added 0.kind: bug Bug (i.e. unthemed components) 5.needs: staff-review A review by a staff member is required/needed labels Mar 12, 2026
uncenter
uncenter reviewed Mar 13, 2026
View reviewed changes
Comment thread styles/desmos/catppuccin.user.less Outdated
uncenter
uncenter reviewed Mar 13, 2026
View reviewed changes
Comment thread styles/desmos/catppuccin.user.less Outdated
uncenter
uncenter reviewed Mar 13, 2026
View reviewed changes
Comment thread styles/desmos/catppuccin.user.less Outdated
@scarcekoi @uncenter
fix(desmos): rename testing page comment
1805eb4 
Co-authored-by: uncenter <uncenter@uncenter.dev>
uncenter
uncenter reviewed Mar 13, 2026
View reviewed changes
Comment thread styles/desmos/catppuccin.user.less Outdated
uncenter
uncenter reviewed Mar 13, 2026
View reviewed changes
Comment thread styles/desmos/catppuccin.user.less Outdated
scarcekoi and others added 2 commits March 13, 2026 19:01
@scarcekoi @uncenter
fix(desmos): remove comment
803dc70 
Co-authored-by: uncenter <uncenter@uncenter.dev>
@scarcekoi @uncenter
fix(desmos): remove comment
2d66ae3 
Co-authored-by: uncenter <uncenter@uncenter.dev>
uncenter
uncenter reviewed Mar 13, 2026
View reviewed changes
Comment thread styles/desmos/catppuccin.user.less Outdated
uncenter
uncenter reviewed Mar 17, 2026
View reviewed changes
Comment thread styles/desmos/catppuccin.user.less Outdated
scarcekoi and others added 2 commits March 17, 2026 14:59
@scarcekoi @uncenter
fix(desmos): nest
6e08d92 
Co-authored-by: uncenter <uncenter@uncenter.dev>
@scarcekoi
style(desmos): fix semicolons and spacing
ebbd982
uncenter
uncenter reviewed Mar 18, 2026
View reviewed changes
Comment thread styles/desmos/catppuccin.user.less Outdated
uncenter
uncenter reviewed Apr 14, 2026
View reviewed changes
Comment thread styles/desmos/catppuccin.user.less
Comment on lines +1193 to +1195
.dcg-shared-account-dialog {
color: @text;
}
Copy link
Copy Markdown
Member

@uncenter uncenter Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what the difference is between .dcg-shared-modal-dialog and .dcg-shared-account-dialog? I see the former in the login popup but not the latter.

Copy link
Copy Markdown
Member Author

@scarcekoi scarcekoi Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember where it was used but it is:

.dcg-shared-account-dialog {
  color:#333
}

@uncenter uncenter changed the title fix(desmos): misc fix(desmos): landing announcement, additional pages, login modal Apr 14, 2026
@uncenter uncenter added 2.status: changes-requested Changes requested by reviewers must be attended to by author before further review and removed 5.needs: staff-review A review by a staff member is required/needed labels Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uncenter uncenter uncenter left review comments

@gradylink gradylink gradylink left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

0.kind: bug Bug (i.e. unthemed components) 2.status: changes-requested Changes requested by reviewers must be attended to by author before further review desmos Desmos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Desmos: Sign Up/Log In Page Partially Unthemed

4 participants

@scarcekoi @uncenter @gradylink @WalkQuackBack