fix: Refine the border.variant color token across all themes#127
Open
danilo-leal wants to merge 1 commit intocatppuccin:mainfrom
Open
fix: Refine the border.variant color token across all themes#127danilo-leal wants to merge 1 commit intocatppuccin:mainfrom
border.variant color token across all themes#127danilo-leal wants to merge 1 commit intocatppuccin:mainfrom
Conversation
|
I believe you should update zed.tera instead. Both json files are generated from that template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey all, I'm one of Zed's designers and Catpuccin is our most downloaded theme ever, and the second most downloaded extension; awesome work all around. However, there has been an ongoing problem with it and that's the
border.varianttoken. It just looks way too bright in all theme variants when it's actually supposed to be a less emphasized border color than its siblingborder. I've had many user reports thinking that was a bug due to how certain elements end up emphasized, so I thought I'd open this PR to fix it. I used the same colors in both the "mauve" and "no italics" variants, too.Here's a preview — you can see mainly how the border below the toolbar looks properly darker and de-emphasized:
The actual colors were achieved by tweaking the lightness and saturation of the previous colors, maintaining the hue.