CsfyTask8565_Fix_the_issues_due_to_CmampTask10710_2#1203
Merged
Conversation
…n_on_server_and_CI
…n_on_server_and_CI
* HelpersTask553: Fix path * HelpersTask553: Update doc
* HelpersTask553: Fix path * HelpersTask553: Update doc * HelpersTask553: Use tempfile
* HelpersTask530: Update contributor feedback doc * HelpersTask530: Improve style * HelpersTask530: Improve style
* HelpersTask464: changed code to use is_header instead of regex directly * HelpersTask464: Fixed the comment and variable name --------- Co-authored-by: Neomi <nsule@umd.edu> Co-authored-by: Sonya Nikiforova <son.nik@mail.ru>
* First test case operation for test_hmarkdown.py * Use assert_equal(dedent=True), set eg 4, 5, set tests 1-7 and removed test_no_code * Removed additional functions * Capitalized Python in comments and set code in inline * Remove hprint.dedent() in test4 in test_hmarkdown.py * Removed & and reduced content in test 3 * Change in comment for test6 --------- Co-authored-by: Sonya Nikiforova <son.nik@mail.ru>
* HelpersTask540: bare links capitalized in md files * Updated nits * Updated comments
* CmampTask11789: fix submodules * CmampTask11789: path * CmampTask11789: fix in the common_run_tests.yml * CmampTask11789: depth * CmampTask11789: ssh * CmampTask11789: name * CmampTask11789: swap names * CmampTask11789: change var * CmampTask11789: caller * CmampTask11789: test secrets * CmampTask11789: playing around * CmampTask11789: one more token * CmampTask11789: secrets * CmampTask11789: fix submodules * CmampTask11789: path * CmampTask11789: fix in the common_run_tests.yml * CmampTask11789: depth * CmampTask11789: ssh * CmampTask11789: name * CmampTask11789: swap names * CmampTask11789: change var * CmampTask11789: caller * CmampTask11789: test secrets * CmampTask11789: playing around * CmampTask11789: one more token * CmampTask11789: secrets * CmampTask11789: revert debug and change token * CmampTask11789: fix token * CmampTask11789: revert token * CmampTask11789: script for PYTHONPATH * CmampTask11789: delete ssh update pythonpath * CmampTask11789: simplify * CmampTask11789: recursive * CmampTask11789: lint and delete script * CmampTask11789: comment * CmampTask11789: remove unnecessary comments * CmampTask11789: comment * CmampTask11789: echo --------- Co-authored-by: vlady <v.yakovenko@crypto-kaizen.com> Co-authored-by: Samarth KaPatel <samarth.kapatel5@gmail.com>
Shayawnn
deleted the
CsfyTask8565_Fix_the_issues_due_to_CmampTask10710_2
branch
PomazkinG
reviewed
Apr 20, 2026
| """ | ||
| if not has_docker(): | ||
| return False | ||
| if not has_dind_support() and not use_docker_sibling_containers(): |
Contributor
There was a problem hiding this comment.
@heanhsok could you ptal at the error below? I think because of this change, it does not work via AirFlow anymore.
error:
Traceback (most recent call last):
File "/venv/bin/invoke", line 8, in <module>
sys.exit(program.run())
^^^^^^^^^^^^^
File "/venv/lib/python3.12/site-packages/invoke/program.py", line 398, in run
self.execute()
File "/venv/lib/python3.12/site-packages/invoke/program.py", line 583, in execute
executor.execute(*self.tasks)
File "/venv/lib/python3.12/site-packages/invoke/executor.py", line 140, in execute
result = call.task(*args, **call.kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/venv/lib/python3.12/site-packages/invoke/tasks.py", line 138, in __call__
result = self.body(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/helpers_root/helpers/lib_tasks_print.py", line 92, in print_env
henv.env_to_str(
File "/app/helpers_root/helpers/henv.py", line 536, in env_to_str
msg += get_system_signature()[0] + "\n"
^^^^^^^^^^^^^^^^^^^^^^
File "/app/helpers_root/helpers/henv.py", line 498, in get_system_signature
txt_tmp = hserver.get_docker_info()
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/helpers_root/helpers/hserver.py", line 735, in get_docker_info
docker_needs_sudo_ = docker_needs_sudo()
^^^^^^^^^^^^^^^^^^^
File "/app/helpers_root/helpers/hserver.py", line 645, in docker_needs_sudo
assert False, "Failed to run docker"
^^^^^
AssertionError: Failed to run docker
@samarth9008 FYI
Contributor
Author
There was a problem hiding this comment.
@PomazkinG, could we try to add back in those 2 removed lines, release from a feature branch, and test on Airflow again, if it works as a quick fix? I will try to understand how this change affects other containerized workflows in detail.
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task https://github.com/causify-ai/csfy/issues/8565
Stack PR on top of #731 with the fixes