dods: implement tactical reload in TacticalMonitorTask#9
Open
petejefferson wants to merge 1 commit intocaxanga334:mainfrom
Open
dods: implement tactical reload in TacticalMonitorTask#9petejefferson wants to merge 1 commit intocaxanga334:mainfrom
petejefferson wants to merge 1 commit intocaxanga334:mainfrom
Conversation
550764a to
31c6d98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements tactical reload behaviour for DoDS bots.
Previously,
CDoDSBotTacticalMonitorTask::OnTaskUpdate()was empty,so bots would never reload unless forced to by the game engine (i.e.
empty clip mid-combat). This caused bots to enter engagements with
partially-spent magazines.
Changes
dodsbot_tactical_monitor_task.h: addCountdownTimer m_reloadCheckTimerto throttle the reload check to once per second.
dodsbot_tactical_monitor_task.cpp:static bool NeedsReload(const CDoDSBotWeapon*, const CBaseBot*)helper that correctly handles:
reload does nothing for these.
m_iMaxClip1viaProp_Datato detect whetherthe clip is below maximum capacity. Falls back to empty-only reload
if the property cannot be read.
OnTaskUpdate(): once per second, if no enemy has been visiblein the last 5 seconds, call
PressReloadButton()whenNeedsReload()returns true.
The 5-second visibility window mirrors the rcbot2 reference implementation
(
m_fLastSeeEnemy + 5.0f).