Skip to content
This repository was archived by the owner on Jan 31, 2024. It is now read-only.

hooked dx & implemented imgui#2

Open
iWanheda wants to merge 4 commits intocazzwastaken:masterfrom
iWanheda:master
Open

hooked dx & implemented imgui#2
iWanheda wants to merge 4 commits intocazzwastaken:masterfrom
iWanheda:master

Conversation

@iWanheda
Copy link
Copy Markdown
Contributor

@iWanheda iWanheda commented Mar 28, 2022

since you've done a tutorial on this already i thought of just doing it the fashion way and boom your base has a menu now for future work, i didn't disable game input left that as an exercise for the reader/user

edit: i should mention i did not restore wndproc or release dx so you might crash upon uninject, another exercise for the reader :D

@L1ghtingBolt
Copy link
Copy Markdown

Bump.

@nickmonick
Copy link
Copy Markdown

accept no kizzy

@cazzwastaken
Copy link
Copy Markdown
Owner

I will merge this soon. I've left it a bit too long deciding whether or not to add it, so there a few conflicts.

@xCENTx
Copy link
Copy Markdown

xCENTx commented Jun 7, 2022

I think leaving crucial things like an unhook as an exercise to the reader would be counter intuitive for this source. It's honestly one of my biggest gripes with "source" hacks such as this. Either do it right and show how its done correctly, or leave the whole thing for somebody to figure out on their own.

My thoughts on it. In fact, ill probably pr your pr so that it will get done right.
Caz has a really decent thing going here and I just think having an unhook crash the program just ruins the whole experience.
How do you debug your dll if you cant attach and detach at will. While very basic and a reader should probably have those things figured out already .... some people might pick this as there first material to learn from.

A decent reader exercise would be as follows:
Leave things like 3d boxes with an esp for the reader to figure out after you shown them a snap line to the target along with everything required to get to that point.

Also , it would be a big win having it done right , as most sources conveniently leave it out

Comment thread src/core/hooks.cpp

LRESULT __stdcall hooks::WndProcess(HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam)
{
if (GetAsyncKeyState(GUI_KEY) & 1)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use GetAsyncKeyState in WndProc??? Just check wParam(?) and uMsg 😟

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants