fix: pool metrics + YAML pool config (#114, #115)#116
Merged
Conversation
…#114, #115) The pool Prometheus counters (connection_pool_likely_new_total, connection_pool_likely_reused_total, connection_pool_reuse_rate_percent) were registered but never incremented — always reported 0. Now record_request() updates them alongside the in-memory stats. Also adds an optional `pool` section to the YAML config so pool behavior (maxIdlePerHost, idleTimeoutSecs) can be controlled per-test via POST /config without restarting the process. Closes #114 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connection_pool_likely_new_total,connection_pool_likely_reused_total,connection_pool_reuse_rate_percent,connection_pool_requests_total) were registered but never incremented — always 0. Now updated on every request in both legacy and scenario worker paths.poolsection to YAML config so connection pool behavior can be set per-test viaPOST /config:Test plan
connection_pool_reuse_rate_percentis non-zero in Prometheuspool: { maxIdlePerHost: 0, idleTimeoutSecs: 0 }and verifyconnection_pool_likely_new_totalclimbs (no reuse)poolsection and verify connections are reused (env-var defaults)Closes #114
🤖 Generated with Claude Code