feat: add configurable newConnectionThresholdMs to YAML pool config#117
Merged
feat: add configurable newConnectionThresholdMs to YAML pool config#117
Conversation
The pool stats tracker uses a latency heuristic to classify requests as
new vs reused connections. The default 100ms threshold doesn't fit all
environments — fast targets can complete a full TLS handshake under
100ms, making new connections appear reused.
Now configurable per-test via YAML:
config:
pool:
newConnectionThresholdMs: 50
The threshold is applied and pool stats are reset on each POST /config.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… pool docs Rename makes it clear the setting only affects the Prometheus metrics heuristic — not actual connection behavior. Added docs/CONNECTION_POOL.md with use cases for new-connection-per-request, default reuse, and long-lived keepalive patterns. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pool stats tracker uses a latency heuristic to classify requests as new vs reused connections. The default 100ms threshold doesn't fit all environments — fast targets can complete a full TLS handshake under 100ms, making new connections appear reused.
Now configurable per-test via YAML:
config:
pool:
newConnectionThresholdMs: 50
The threshold is applied and pool stats are reset on each POST /config.