feat: accurate connection tracking via local port (#119)#120
Merged
Conversation
#119) Remove the unreliable latency-based heuristic (likely_new/likely_reused) and replace with deterministic local TCP port tracking. Each response's local SocketAddr is extracted from hyper's HttpInfo — a new local port means a new TCP connection, same port means reused. Breaking metric changes: - Removed: connection_pool_likely_new_total - Removed: connection_pool_likely_reused_total - Added: connection_pool_new_total - Added: connection_pool_reused_total - connection_pool_reuse_rate_percent now uses accurate tracking - Removed: metricsReuseThresholdMs YAML field (no longer needed) Closes #119 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Tests now use SocketAddr-based record_request() and the new ConnectionStats fields (new_connections, reused_connections). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
likely_new/likely_reused) with deterministic local TCP port trackingSocketAddris extracted from hyper'sHttpInfo— a new local port = new TCP connection, same port = reusedmetricsReuseThresholdMsYAML field (no longer needed)docs/CONNECTION_POOL.mdwith accurate metric names and Grafana queriesBreaking Metric Changes
connection_pool_likely_new_totalconnection_pool_new_totalconnection_pool_likely_reused_totalconnection_pool_reused_totalconnection_pool_reuse_rate_percentis kept but now uses accurate tracking.Test plan
connection_pool_reused_totalclimbspool: { maxIdlePerHost: 0, idleTimeoutSecs: 0 }— verifyconnection_pool_new_totalclimbsCloses #119
🤖 Generated with Claude Code