Skip to content

fix(git): require abort when asked to add Signed-off-by#28

Merged
cblecker merged 1 commit intomainfrom
fix/git-signed-off-by-abort
Mar 10, 2026
Merged

fix(git): require abort when asked to add Signed-off-by#28
cblecker merged 1 commit intomainfrom
fix/git-signed-off-by-abort

Conversation

@cblecker
Copy link
Owner

@cblecker cblecker commented Mar 10, 2026

Summary

  • Strengthens the DCO safety rule in git-instructions.sh: Claude now explicitly aborts and explains why when asked to add a Signed-off-by tag, rather than just passively never adding it
  • Bumps git plugin patch version from 1.1.0 to 1.1.1

Test plan

  • Verify the SessionStart hook still outputs valid instructions by running bash git/scripts/git-instructions.sh in a git repo
  • Confirm claude plugin validate ./git passes with the new version

Summary by CodeRabbit

  • Chores
    • Version updated to 1.1.1
    • Updated commit validation guidance for handling signature-related requests

Strengthen the DCO safety rule so Claude explicitly aborts the request
and explains why, rather than just passively never adding the tag.

Assisted-by: Claude:claude-sonnet-4-6
@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 33068c6f-36f8-4e16-9739-c26764bab9c9

📥 Commits

Reviewing files that changed from the base of the PR and between 4fac223 and afbf88d.

📒 Files selected for processing (2)
  • git/.claude-plugin/plugin.json
  • git/scripts/git-instructions.sh

Walkthrough

Plugin version incremented from 1.1.0 to 1.1.1, and git commit guidance for Signed-off-by tags modified to instruct aborting requests instead of disallowing them.

Changes

Cohort / File(s) Summary
Plugin Metadata
git/.claude-plugin/plugin.json
Version field updated from "1.1.0" to "1.1.1".
Git Instructions
git/scripts/git-instructions.sh
Commit guidance for Signed-off-by tags changed from disallowing to aborting user requests for such tags.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 A minor hop, a version so fine,
From one-one-oh to one-one-one aligned,
Signed-off requests now take a bow,
Abort the ask, we know the vow!
Small changes spark, our plugin's glow ✨

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(git): require abort when asked to add Signed-off-by' directly and clearly describes the main change in the pull request: modifying git-instructions.sh to abort (instead of passively omit) when asked to add Signed-off-by tags.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/git-signed-off-by-abort

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cblecker cblecker merged commit f3fd7ee into main Mar 10, 2026
7 checks passed
@cblecker cblecker deleted the fix/git-signed-off-by-abort branch March 10, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant