feat: add keymaps for floating window#174
Conversation
edwardbaeg
left a comment
There was a problem hiding this comment.
Very excited about this new feature!
|
@cbochs friendly bump :)) |
|
@tronikelis apologies for the late reply. I was away on vacation for the past several weeks. Will take a look here soon 🙂 |
cbochs
left a comment
There was a problem hiding this comment.
This is a good start to making mappings more customizable! Left a couple comments.
One note: I think (at least for now) I would prefer that the go_up_scope be fixed. It doesn't have a good common action between the different windows. For example, Tags -> Scopes, Scopes -> Loaded (containers), Loaded (containers) -> Scopes.
It almost feels like there should be separate maps for each:
tag_mappings = { go_to_scopes = "-" }
scope_mappings = { go_to_loaded = "-" }
loaded_mappings = { go_to_scopes = "-" }But needs a bit more thought, I think. In addition, I don't really like the name loaded. It obscures what is this window is really for: Grapple containers. Something I would like to resolve in the near future would be to rename this from "loaded" to "containers".
|
|
||
| --Override default floating window mappings | ||
| win_mappings = { | ||
| toggle_hidden = "g.", |
There was a problem hiding this comment.
Some action name change suggestions:
unload_scope->unloadand put in theloaded_mappingstablereset_scope->resetand put in theloaded_mappingstablechange_scope->changeand put in thescope_mappingstableselect_horizontal->select_splitand put in thetag_mappingstableselect_vertical->select_vsplitand put in thetag_mappingstable
There was a problem hiding this comment.
thanks for the insights, I'll change it
There was a problem hiding this comment.
did you list all the renames here? Or is something left
|
@cbochs I've changed the names based on your comments, please check if I got everything right |
|
@cbochs could we get this merged? |
|
@cbochs 🥲 |
closes #172
I am up for discussion on how to call these settings and where to put them
fyi I tested the changes locally
Another approach would be to architecture settings like this:
Not really sure which one's betteer