Skip to content

Fixes issue of empty CBOM creation when no SonarQube rule is activated #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
medha-14 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

Fixes issue of empty CBOM creation when no SonarQube rule is activated #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sonar-cryptography-plugin/src/main/java/com/ibm/plugin/OutputFileJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ public void execute(PostJobContext postJobContext) {
.get(Constants.CBOM_OUTPUT_NAME)
.orElse(Constants.CBOM_OUTPUT_NAME_DEFAULT);
ScannerManager scannerManager = new ScannerManager(new CBOMOutputFileFactory());
if (!scannerManager.hasResults()) {
LOGGER.info("No cryptography assets were detected. CBOM will not be generated.");
scannerManager.reset();
return;
}
final File cbom = new File(cbomFilename + ".json");
scannerManager.getOutputFile().saveTo(cbom);
LOGGER.info("CBOM was successfully generated '{}'.", cbom.getAbsolutePath());
Expand Down