Fix Auto Review follow-up findings#340
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #329
Summary
code/codexcommand wrappersValidation
cargo test -p code-core supersede_by_fingerprint_omits_runs_with_findings_and_errors --libcargo test -p code-core large_custom_code_command_prompt_uses_stdin --lib./build-fast.shAuto Review
Addresses findings from Auto Review agent
23c0c1beon snapshotc9ce47309ed3f8a0494a1bdb84fe6c642b9d5bde:[P2] Preserve failed reviews when superseding duplicate fingerprints[P2] Keep stdin delivery for custom code/codex commands