Skip to content

Allow global runtime secret bindings in safety routing #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbusillo merged 1 commit into from
Jun 3, 2026
Merged

Allow global runtime secret bindings in safety routing #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions control_plane/runtime_key_safety.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,10 +220,12 @@ def _effective_bindings_for_target(


def _binding_route_rank(*, binding: SecretBinding, target: RuntimeKeySafetyTarget) -> int:
if not binding.context and not binding.instance:
return 1
if binding.context == target.context and binding.instance == target.instance:
return 2
return 3
if binding.context == target.context and not binding.instance:
return 1
return 2
return 0


Expand Down
61 changes: 61 additions & 0 deletions tests/test_runtime_key_safety.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,67 @@ def test_unrelated_context_binding_does_not_satisfy_target(self) -> None:
self.assertEqual(evaluation.findings[0].code, "binding_missing")
self.assertEqual(evaluation.findings[0].binding_key, "ODOO_ADMIN_PASSWORD")

def test_global_binding_satisfies_allowed_shared_target(self) -> None:
evaluation = evaluate_runtime_key_safety(
target=RuntimeKeySafetyTarget(
context="cm",
instance="prod",
environment_class="prod",
),
required_binding_keys=("ODOO_DB_PASSWORD",),
secret_bindings=(
_binding(
binding_key="ODOO_DB_PASSWORD",
binding_id="binding-global-db-password",
secret_id="secret-global-db-password",
).model_copy(update={"context": "", "instance": ""}),
),
secret_rules=(
RuntimeSecretSafetyRule(
binding_key="ODOO_DB_PASSWORD",
secret_class="shared_safe",
allowed_contexts=("cm", "opw"),
allowed_instances=("testing", "prod"),
),
),
)

self.assertEqual(evaluation.status, "pass")
self.assertEqual(evaluation.findings, ())

def test_context_binding_takes_precedence_over_global_binding(self) -> None:
evaluation = evaluate_runtime_key_safety(
target=RuntimeKeySafetyTarget(
context="cm",
instance="prod",
environment_class="prod",
),
required_binding_keys=("ODOO_DB_PASSWORD",),
secret_bindings=(
_binding(
binding_key="ODOO_DB_PASSWORD",
binding_id="binding-global-db-password",
secret_id="secret-global-db-password",
).model_copy(update={"context": "", "instance": ""}),
_binding(
binding_key="ODOO_DB_PASSWORD",
binding_id="binding-context-db-password",
secret_id="secret-context-db-password",
).model_copy(update={"context": "cm", "instance": ""}),
),
secret_rules=(
RuntimeSecretSafetyRule(
binding_key="ODOO_DB_PASSWORD",
secret_class="prod_only",
allowed_contexts=("cm",),
allowed_instances=("prod",),
),
),
)

self.assertEqual(evaluation.status, "pass")
self.assertEqual(evaluation.findings, ())

def test_equally_specific_duplicate_bindings_remain_ambiguous(self) -> None:
evaluation = evaluate_runtime_key_safety(
target=RuntimeKeySafetyTarget(
Expand Down