Harden skill catalog install and validation#4
Merged
ccarvalho-eng merged 1 commit intomainfrom Apr 19, 2026
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThis PR introduces a skill manifest system for tracking installed skills, enabling automatic pruning of removed skills. A new validation workflow and script verify skill catalogs for broken references and test install/uninstall operations. Both install and uninstall scripts now support Changes
Sequence DiagramsequenceDiagram
participant User
participant install.sh
participant Manifest as Manifest File
participant Skills as Skill Dirs
participant uninstall.sh
User->>install.sh: Run install.sh [--dry-run]
install.sh->>Skills: Read source skill directories
install.sh->>Skills: Prune previously installed skills<br/>no longer in source
install.sh->>Skills: Copy/install current source skills
install.sh->>Manifest: Write current skill inventory
Manifest-->>install.sh: Manifest updated
Note over install.sh: With --dry-run, no<br/>filesystem modifications
User->>uninstall.sh: Run uninstall.sh [--dry-run]
uninstall.sh->>Manifest: Read owned skills from manifest
uninstall.sh->>Skills: Remove all owned skill directories
uninstall.sh->>Manifest: Delete manifest file
Manifest-->>uninstall.sh: Manifest removed
Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR tightens the skill-pack maintenance flow so local installs are safer and catalog drift is caught automatically.
It fixes the stale
elixir-phoenix-compoundcross-skill references, makes.worktrees/untracked, hardensinstall.shso--dry-runis non-mutating, and adds manifest-based pruning/removal so repo-managed stale skills do not linger in local Codex installs. It also adds a catalog validator script and a GitHub Actions workflow to catch broken localreferences/...links and script regressions in CI.Why
The repo had a few low-risk maintenance gaps:
install.sh --dry-runstill created the target directoryImpact
Users installing this skill pack get cleaner local updates, predictable dry-run behavior, and automatic pruning of removed skills. Maintainers also get CI coverage for catalog integrity and install/uninstall behavior.
Validation
bash ./scripts/validate_skills.sh~/.codex/skillswithbash ./install.shSummary by CodeRabbit
Release Notes
New Features
--dry-runflag to preview installation and uninstall operations without modifying the filesystemDocumentation
Tests