Open
Conversation
sijie
approved these changes
Jun 20, 2018
| */ | ||
| public class Defaults { | ||
|
|
||
| public static final String SERVICE_URL = "pulsar://localhost:6650"; |
There was a problem hiding this comment.
I think flink is using tab for indents if I remembered directly. it might be worth double-checking before you send the pull request.
| @@ -0,0 +1,22 @@ | |||
| package org.apache.flink.streaming.connectors.pulsar; | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request adds a pulsar source connector which will enable flink jobs to process messages from pulsar topics.
Brief change log
Verifying this change
This change adds unit test to verify checkpointing and batch message acknowledgements.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation