fix(docker): copy cbits/ before gen-cabal-config.sh#23
Merged
Conversation
PR #20 made gen-cabal-config.sh compile cbits/static-shims.c into a .o that the static link pulls in, but docker/Dockerfile still only copies volca.cabal, mumps-hs/ and gen-cabal-config.sh into the builder before invoking the script. The cc step fails with: cc1: fatal error: /build/volca/cbits/static-shims.c: No such file or directory so the SaaS / volca image build breaks at step 11. Add a COPY for cbits/ next to the other dependency-spec copies so the layer cache still invalidates only when shim sources change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker/Dockerfilefailed at thegen-cabal-config.shstep withcc1: fatal error: /build/volca/cbits/static-shims.c: No such file or directory.gen-cabal-config.shcompilecbits/static-shims.cto a.oconsumed by the static link, but the Dockerfile only copiesvolca.cabal,mumps-hs/andgen-cabal-config.shinto the builder before invoking the script.COPY cbits/ /build/volca/cbits/next to the other dep-spec copies, so the shim source is present when the script runs and layer caching only invalidates when shim sources change.Test plan
./volca/docker-build.sh(against this branch) progresses past step 11 — confirmed locally up tocabal build --only-dependencies volca.docker run volca --versionworks.