Skip to content

Fix broken helpdesk layout when satisfaction survey is expired#1

Open
cdbaq wants to merge 1 commit into
11.0/bugfixesfrom
cdbaq-patch-1
Open

Fix broken helpdesk layout when satisfaction survey is expired#1
cdbaq wants to merge 1 commit into
11.0/bugfixesfrom
cdbaq-patch-1

Conversation

@cdbaq
Copy link
Copy Markdown
Owner

@cdbaq cdbaq commented Apr 16, 2026

Checklist before requesting a review

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes #<issue_number>

  • This PR fixes a broken layout in the helpdesk/self-service interface when viewing closed tickets with an expired or external satisfaction survey.

    In some survey paths, timeline.html.twig opens a wrapper <div> and <form>, but itilsatisfaction.html.twig does not always close them because buttons.html.twig is not rendered in those cases.

    This leaves unclosed markup and causes .itil-right-side to be rendered inside .itil-left-side, breaking the expected two-column layout.

    The fix adds explicit closing tags in the survey paths where buttons.html.twig is not rendered:

    • external survey
    • expired survey with no answer
    • expired survey with an existing answer

Screenshots (if appropriate):

  • Before: closed ticket layout breaks in helpdesk when the satisfaction survey is expired.
  • After: .itil-right-side is rendered again as a sibling of .itil-left-side.

Close the wrapper div and form in survey paths where buttons.html.twig is not rendered.

This fixes a broken helpdesk layout on closed tickets when the satisfaction survey is expired or external.
@cdbaq cdbaq force-pushed the 11.0/bugfixes branch 4 times, most recently from 8bda44c to 6c82f55 Compare May 13, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant