Fix broken helpdesk layout when satisfaction survey is expired#1
Open
cdbaq wants to merge 1 commit into
Open
Conversation
Close the wrapper div and form in survey paths where buttons.html.twig is not rendered. This fixes a broken helpdesk layout on closed tickets when the satisfaction survey is expired or external.
8bda44c to
6c82f55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
It fixes #<issue_number>
This PR fixes a broken layout in the helpdesk/self-service interface when viewing closed tickets with an expired or external satisfaction survey.
In some survey paths,
timeline.html.twigopens a wrapper<div>and<form>, butitilsatisfaction.html.twigdoes not always close them becausebuttons.html.twigis not rendered in those cases.This leaves unclosed markup and causes
.itil-right-sideto be rendered inside.itil-left-side, breaking the expected two-column layout.The fix adds explicit closing tags in the survey paths where
buttons.html.twigis not rendered:Screenshots (if appropriate):
.itil-right-sideis rendered again as a sibling of.itil-left-side.