Playing with this idea as a strategy pattern#2
Open
dfinke wants to merge 4 commits intocdhunt:masterfrom
dfinke:master
Open
Playing with this idea as a strategy pattern#2dfinke wants to merge 4 commits intocdhunt:masterfrom dfinke:master
dfinke wants to merge 4 commits intocdhunt:masterfrom
dfinke:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know if this is a good way to chat.
Instead of having two two functions one that can take a scriptblock and one that takes a file
open/close principle
be open for extension, but closed for modification
an entity can allow its behaviour to be extended without modifying its source code