Skip to content

Script to deprecate rules created#54

Merged
SFJohnson24 merged 1 commit into
mainfrom
50-cdisc-engine-should-run-published-rules-tests-on-non-sdtm-only
Jun 15, 2026
Merged

Script to deprecate rules created#54
SFJohnson24 merged 1 commit into
mainfrom
50-cdisc-engine-should-run-published-rules-tests-on-non-sdtm-only

Conversation

@gerrycampion

@gerrycampion gerrycampion commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Script is here: https://github.com/cdisc-org/cdisc-open-rules/pull/54/changes#diff-8d2a53cfec127216c271b238150dac2e5e0327c740579329777bcdee98a26b79

This PR moves published rules to a deprecated folder using the logic described in the attached ticket.

@gerrycampion gerrycampion linked an issue Jun 11, 2026 that may be closed by this pull request
@github-actions

Copy link
Copy Markdown

Schema Validation Results

Click to expand

Schema Validation Report

Schema: https://raw.githubusercontent.com/cdisc-org/cdisc-rules-engine/refs/heads/main/resources/schema/rule-merged/CORE-base.json

Files checked: 0 | Failed: 0

View workflow run

@gerrycampion gerrycampion marked this pull request as ready for review June 11, 2026 13:11
@gerrycampion gerrycampion added this to the v1.0.0 milestone Jun 11, 2026

@SFJohnson24 SFJohnson24 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good--should we also move the Unpublished/SDTMIG & FDA Business into deprecrated @gerrycampion?

@gerrycampion

Copy link
Copy Markdown
Collaborator Author

This looks good--should we also move the Unpublished/SDTMIG & FDA Business into deprecrated @gerrycampion?

good question. i guess it's not immediately necessary at this time

@RamilCDISC RamilCDISC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script accurately moves the published SDTM/FDA only SDTMIG rules to deprecated folder. Validation has been done by reviewing the moved and unmoved rules folder. All the moved folders are moved fully with their test data.

@SFJohnson24 SFJohnson24 merged commit 89268d0 into main Jun 15, 2026
5 checks passed
@SFJohnson24 SFJohnson24 deleted the 50-cdisc-engine-should-run-published-rules-tests-on-non-sdtm-only branch June 15, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CDISC engine should run published rules tests on non-sdtm only

3 participants