Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/validate-rule-contributions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
python -m venv venv
git submodule update --init --recursive
./venv/bin/pip install --upgrade pip
./venv/bin/pip install -r engine/requirements.txt
./venv/bin/pip install -e engine/

# -----------------------------------------------------------------------
# Detect which rule changed
Expand Down
8 changes: 0 additions & 8 deletions Published/CORE-000084/negative/02/results/results.csv
Original file line number Diff line number Diff line change
@@ -1,14 +1,6 @@
Dataset,Record,Variable,Value
<<<<<<< HEAD
AE,0,AEENTPT,2013-05-20
AE,1,AEENTPT,2013-05-20
AE,2,AEENTPT,2013-01-14
AE,3,AEENTPT,2013-01-14
AE,4,AEENTPT,
=======
AE.csv,1,AEENTPT,2013-05-20
AE.csv,2,AEENTPT,2013-05-20
AE.csv,3,AEENTPT,2013-01-14
AE.csv,4,AEENTPT,2013-01-14
AE.csv,5,AEENTPT,
>>>>>>> main
22 changes: 3 additions & 19 deletions setup/bash_setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,6 @@
# Contributor setup script for Mac/Linux
set -e

INSTALL_BINARY=false

# Parse flags to set INSTALL_BINARY=true if -b or --binary passed
while [[ "$#" -gt 0 ]]; do
case $1 in
-b|--binary) INSTALL_BINARY=true ;;
*) echo "Unknown parameter passed: $1"; exit 1 ;;
esac
shift
done

command_exists() {
command -v "$1" >/dev/null 2>&1
}
Expand Down Expand Up @@ -134,14 +123,9 @@ source venv/bin/activate
echo "Installing dependencies..."
pip install --upgrade pip --quiet

if [ "$INSTALL_BINARY" = true ]; then
echo "Installing with psycopg2-binary swap..."
sed 's/^psycopg2==/psycopg2-binary==/g' engine/requirements.txt | pip install --quiet -r /dev/stdin
grep -v "^-r requirements.txt" engine/requirements-dev.txt | pip install --quiet -r /dev/stdin
else
echo "Installing standard requirements..."
pip install -r engine/requirements-dev.txt --quiet
fi
echo "Installing standard requirements..."
pip install --quiet -e engine/[dev]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current engine in the repo defines a 'dev' dependency group instead of dev extra. Here it seems like it is trying to install a dev extra. Please let me know if I am confusing something.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is the [dev] devependency group in the pyproject.toml file



VENV_PYTHON=$(which python)

Expand Down
24 changes: 1 addition & 23 deletions setup/windows_setup.bat
Original file line number Diff line number Diff line change
Expand Up @@ -147,29 +147,7 @@ echo.
echo Installing dependencies...
python -m pip install --upgrade pip setuptools wheel --quiet

if not exist "engine/requirements.txt" (
echo requirements.txt not found in engine directory
cd ..
pause
exit /b 1
)

python -m pip install -r engine/requirements.txt --quiet
if !errorlevel! neq 0 (
echo Failed to install dependencies
cd ..
pause
exit /b 1
)

if not exist "engine/requirements-dev.txt" (
echo requirements-dev.txt not found in engine directory
cd ..
pause
exit /b 1
)

python -m pip install -r engine/requirements-dev.txt --quiet
python -m pip install -e engine/[dev] --quiet
if !errorlevel! neq 0 (
echo Failed to install dependencies
cd ..
Expand Down