Skip to content

Updated detailed diff algo to unordered#57

Merged
SFJohnson24 merged 16 commits into
mainfrom
unordered-diff-results
Jun 23, 2026
Merged

Updated detailed diff algo to unordered#57
SFJohnson24 merged 16 commits into
mainfrom
unordered-diff-results

Conversation

@gerrycampion

@gerrycampion gerrycampion commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

For Published rules testing, this improves the reporting of failed tests in the detailed report.

  • Uses markdown table to display differences
  • Aligns differences using closest row match instead of strictly row number
  • Uploads both the expected and actual results to artifacts instead of only the expected results

Action run before update: https://github.com/cdisc-org/cdisc-rules-engine/actions/runs/27967250482
Action run after update: https://github.com/cdisc-org/cdisc-rules-engine/actions/runs/27973685763

Requires PR: cdisc-org/cdisc-rules-engine#1769

@gerrycampion gerrycampion changed the title Updated detailed diff algo Updated detailed diff algo to unordered Jun 18, 2026
@gerrycampion gerrycampion added this to the v1.0.0 milestone Jun 18, 2026

@SFJohnson24 SFJohnson24 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes correctly implement all three stated goals: diff output is now rendered as a GitHub markdown table with similarity-based row pairing, and both expected and actual CSVs are preserved as artifacts. Logic for backing up and restoring the baseline around the engine run is sound.

@SFJohnson24 SFJohnson24 merged commit 4ae040c into main Jun 23, 2026
3 checks passed
@SFJohnson24 SFJohnson24 deleted the unordered-diff-results branch June 23, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants