Skip to content

run test suite and editor preview for all PRs--internal and external #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SFJohnson24 merged 2 commits into from
Jan 12, 2026
Merged

run test suite and editor preview for all PRs--internal and external #1524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63b190c
added branch logic for actions
SFJohnson24 Jan 9, 2026
bdae702
Merge branch 'main' into automate_test_external
SFJohnson24 Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/automated-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ jobs:
test_suite:
uses: ./.github/workflows/test_suite.yml
secrets: inherit
with:
pr_ref: ${{ github.event.pull_request.head.sha }}
rule_tester:
uses: ./.github/workflows/rule-tester.yml
secrets: inherit
Expand All @@ -17,3 +19,5 @@ jobs:
needs: rule_tester
uses: ./.github/workflows/test_rule_editor_preview.yml
secrets: inherit
with:
pr_ref: ${{ github.event.pull_request.head.sha }}
14 changes: 13 additions & 1 deletion .github/workflows/test_rule_editor_preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,17 @@ name: Run Tests on Preview Deployment

on:
workflow_call:
inputs:
pr_ref:
description: "Git reference to checkout (for PRs)"
required: false
type: string
workflow_dispatch:
inputs:
pr_number:
description: "PR number to test (leave empty for current branch)"
required: false
type: string
Comment on lines +11 to +15

@gerrycampion gerrycampion Jan 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should add this to test_unit as well

@SFJohnson24 SFJohnson24 Jan 9, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gerrycampion #1519 this PR resolves the unit tests for outside PRs. Our unit tests dont make any API calls but the config service wants one when it is initialized. If we give the unit tests a fakekey, they run appropriately for all internal and external PRs


jobs:
end_to_end_test:
Expand All @@ -11,12 +21,14 @@ jobs:
steps:
- name: Checkout repo
uses: actions/checkout@v4
with:
ref: ${{ inputs.pr_ref || (inputs.pr_number && format('refs/pull/{0}/head', inputs.pr_number)) || github.ref }}

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.12

- name: Ensure setuptools is installed
run: python -m ensurepip --upgrade && python -m pip install --upgrade pip setuptools

Expand Down
13 changes: 12 additions & 1 deletion .github/workflows/test_suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,17 @@
name: CORE Test Suite Validation
on:
workflow_call:
inputs:
pr_ref:
description: "Git reference to checkout (for PRs)"
required: false
type: string
workflow_dispatch:
inputs:
pr_number:
description: "PR number to test (leave empty for current branch)"
required: false
type: string
env:
DATASET_SIZE_THRESHOLD: 1000000000
jobs:
Expand All @@ -10,7 +20,8 @@ jobs:
steps:
- name: Get Engine Changes
uses: actions/checkout@v4

with:
ref: ${{ inputs.pr_ref || (inputs.pr_number && format('refs/pull/{0}/head', inputs.pr_number)) || github.ref }}
- name: Get Test Suite Repository
uses: actions/checkout@v4
with:
Expand Down
Loading