Add ADaM product standards to StandardTypes CLI gate#1770
Merged
SFJohnson24 merged 1 commit intoJun 22, 2026
Conversation
StandardTypes is the allow-list core.py uses to validate -s/--standard. It lists adamig but not the other six ADaM products in ADAM_PRODUCTS (adam-adae, adam-md, adam-nca, adam-occds, adam-tte, adam-poppk), which are already handled by normalize_standard_input(). As a result a command such as `-s adam-tte` is rejected before the engine runs, even though the engine supports it. Add the six products to StandardTypes, completing the normalization from cdisc-org#1733 (which added adamig and the sendig-* products), and add a test asserting the gate stays in sync with ADAM_PRODUCTS. Signed-off-by: Antony Bevan <antonymichealbevan04@gmail.com>
SFJohnson24
approved these changes
Jun 22, 2026
SFJohnson24
left a comment
Collaborator
There was a problem hiding this comment.
this PR correctly implements the missing adam products in the standard types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StandardTypesis the allow-list the CLI uses to validate-s/--standard. When--custom-standardis not set,core.pyrejects any value not inStandardTypes.values()and exits with code 2. The enum listsadamigbut not theother six ADaM products defined in
ADAM_PRODUCTS(
cdisc_rules_engine/constants/adam_products.py):adam-adae,adam-md,adam-nca,adam-occds,adam-tte,adam-poppk.Those six are already handled by
normalize_standard_input()incdisc_rules_engine/utilities/utils.py, which maps any value inADAM_PRODUCTSto("adam", "<product>-<version>"). Because the gate does not list them, a commandsuch as
-s adam-tte -v 1-0is rejected before the engine runs, even though theengine supports it.
This adds the six products to
StandardTypes, completing the normalization startedin #1733 (which added
adamigand thesendig-*products). The values mirrorADAM_PRODUCTS.Reproduction (current
main)Changes
cdisc_rules_engine/enums/standard_types.py: add the sixadam-*products,following the pattern used for the
sendig-*products.tests/unit/test_utilities/test_standard_types_adam.py: assert that everyADAM_PRODUCTSentry is a validStandardTypesvalue, so the gate and theproduct list cannot drift apart again.
Testing
blackandflake8pass on both files.