fix: replace inplace=True mutation (pandas 3.0 CoW)#1772
Merged
SFJohnson24 merged 1 commit intoJun 22, 2026
Merged
Conversation
Contributor
Author
|
@SFJohnson24 see next commit for pandas 3 upgrade from #1745 |
Draft
SFJohnson24
approved these changes
Jun 22, 2026
SFJohnson24
reviewed
Jun 22, 2026
SFJohnson24
left a comment
SFJohnson24
left a comment
Collaborator
There was a problem hiding this comment.
passes test suite (#1773), high level review, and testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
row.reset_index(drop=True, inplace=True)withrow = row.reset_index(drop=True)innext_column_exists_and_previous_is_null. Pandas 3.0 enforces Copy-on-Write, which makesinplace=Trueon a row (a view of the DataFrame) silently fail instead of modifying the data. This doesn't produce warnings on pandas <3.0 but will break at runtime on pandas 3.0.Tested scenarios: