fix: remove method= and downcast= from fillna (removed in pandas 3.0)#1776
Merged
SFJohnson24 merged 1 commit intoJun 23, 2026
Merged
Conversation
Draft
Contributor
Author
|
@SFJohnson24 another commit from #1745 |
SFJohnson24
approved these changes
Jun 23, 2026
SFJohnson24
left a comment
SFJohnson24
left a comment
Collaborator
There was a problem hiding this comment.
PR correctly removes parameters--passes unittests, test suite (#1779) and pilot study.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
method=anddowncast=parameters fromfillna()inDatasetInterface,PandasDataset, andDaskDataset. Both parameters were deprecated in pandas 2.2.0 and removed in pandas 3.0. No callers in the codebase pass these arguments — they were only present in the method signatures.Tested scenarios: